Skip to content

Pass azureContext to DeployWizard to enable Azure Workload Identity Step#635

Open
tejhan wants to merge 1 commit into
Azure:mainfrom
tejhan:deploymentAzureContext
Open

Pass azureContext to DeployWizard to enable Azure Workload Identity Step#635
tejhan wants to merge 1 commit into
Azure:mainfrom
tejhan:deploymentAzureContext

Conversation

@tejhan
Copy link
Copy Markdown
Collaborator

@tejhan tejhan commented May 4, 2026

Description

Currently our WorkloadIdentityStep is gated by the presence of azureContext, and it appears we aren't passing that into the DeployWizard, thus it's always disabled.

This PR gets and passes the azureContext into DeployWizard via DeployButton, which re-enables this option & provides the context for it's operations.

Fixes issue:

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • CI/CD changes
  • Other: **___**

Related Issues

Closes #617

Changes Made

  • Added azureContext, fetched via useAzureContext
  • Added isManagedNamespace & azureRbacenabled, fetched via useNamespaceCapabilities
  • Passed new azureContext, isManagedNamespace & azureRbacenabled into DeployWizard (to satisfy DeployAzureContext interface)
  • Added azureContextError to surface detailed errors if caught

Testing

  • Unit tests pass
  • Integration tests pass
  • Manual testing completed
  • Performance tested (if applicable)
  • Accessibility tested (if applicable)

Test Cases

Manual Testing:

  1. Click 'Deploy Application`
  2. Navigate to the Workload Identity Step
  3. Observe that the step is now enabled & interactable.

@tejhan tejhan self-assigned this May 4, 2026
Copilot AI review requested due to automatic review settings May 4, 2026 23:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires Azure deployment context into the project-header DeployButton so the Deploy Wizard can enable the Workload Identity step for Azure-backed deployments, addressing issue #617 in the deploy flow.

Changes:

  • Fetches Azure context from the selected project cluster in DeployButton.
  • Fetches namespace capability metadata (isManagedNamespace, azureRbacEnabled) for the selected project namespace.
  • Passes the assembled Azure context into DeployWizard so workload identity setup has the data it needs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aks-desktop/src/components/Deploy/DeployButton.tsx
Comment thread plugins/aks-desktop/src/components/Deploy/DeployButton.tsx Outdated
… Identity step

Signed-off-by: tejhan-diallo <tejhan.diallo@gmail.com>
@tejhan tejhan force-pushed the deploymentAzureContext branch from 94ab106 to 23b8652 Compare May 5, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to toggle on Workload Identity

2 participants