Pass azureContext to DeployWizard to enable Azure Workload Identity Step#635
Open
tejhan wants to merge 1 commit into
Open
Pass azureContext to DeployWizard to enable Azure Workload Identity Step#635tejhan wants to merge 1 commit into
tejhan wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires Azure deployment context into the project-header DeployButton so the Deploy Wizard can enable the Workload Identity step for Azure-backed deployments, addressing issue #617 in the deploy flow.
Changes:
- Fetches Azure context from the selected project cluster in
DeployButton. - Fetches namespace capability metadata (
isManagedNamespace,azureRbacEnabled) for the selected project namespace. - Passes the assembled Azure context into
DeployWizardso workload identity setup has the data it needs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… Identity step Signed-off-by: tejhan-diallo <tejhan.diallo@gmail.com>
94ab106 to
23b8652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently our
WorkloadIdentityStepis gated by the presence ofazureContext, and it appears we aren't passing that into theDeployWizard, thus it's always disabled.This PR gets and passes the
azureContextintoDeployWizardviaDeployButton, which re-enables this option & provides the context for it's operations.Fixes issue:
Type of Change
Related Issues
Closes #617
Changes Made
azureContext, fetched viauseAzureContextisManagedNamespace&azureRbacenabled, fetched viauseNamespaceCapabilitiesazureContext,isManagedNamespace&azureRbacenabledintoDeployWizard(to satisfyDeployAzureContextinterface)azureContextErrorto surface detailed errors if caughtTesting
Test Cases
Manual Testing: