Fix deploy manifest being cut off#636
Open
tejhan wants to merge 1 commit into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The manifest editor on the Deploy step was hardcoded to 60vh, larger than the 55vh component it resided in, resulting in final content being cut off.
Switched to flex layout & modified height to ensure editor content is fully expanded & contained within the view.
Fixes issue:
Type of Change
Related Issues
Closes #625
Changes Made
MonacoEditorheightfrom 60vh -> 100%flex:1,minHeight:0&display:flexproperties to parentBoxTesting
Test Cases
Manual Testing:
Screenshots/Videos
If applicable, add screenshots or videos to demonstrate the changes.