upstreamable: frontend: ProjectDetails: Fix stale custom tabs#639
Open
skoeva wants to merge 1 commit into
Open
upstreamable: frontend: ProjectDetails: Fix stale custom tabs#639skoeva wants to merge 1 commit into
skoeva wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes stale custom/plugin tabs on the Project Details page by scoping tab state to the current route + resolved project identity and preventing async tab eligibility checks from applying after navigation.
Changes:
- Introduces a project identity key derived from route name + project metadata and uses it to remount
ProjectDetailsContent. - Separates custom/plugin tabs from default tabs and clears/reloads custom tabs on project key changes while ignoring stale async results.
- Prevents blank/stale tab selection by falling back to the first available tab when the selected tab disappears.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix stale custom project detail tabs by scoping plugin tab state to the current route and resolved project identity.
Related: #634
Summary
ProjectDetailsContentwhen the route or resolved project identity changesisEnabledchecks reload for the current projectTesting
frontend/src/components/project/PorojectDetails.tsxhas no TS errors