Skip to content

Fix: Align error rate samples to request rate samples #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejhan wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

Fix: Align error rate samples to request rate samples #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions plugins/aks-desktop/src/components/Metrics/hooks/usePrometheusMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,13 +399,18 @@ export function usePrometheusMetrics(

// Process Request & Error data (combined)
if (requestResults.length > 0 && requestResults[0].values) {
requestResults[0].values.forEach((v: [number, string], idx: number) => {
// Create a map of error values keyed by timestamp for correct alignment with
// request values, since Prometheus may return different timestamps for each query.
const errorByTimestamp = new Map<number, number>();
if (errorResults.length > 0 && errorResults[0].values) {
errorResults[0].values.forEach((v: [number, string]) => {
errorByTimestamp.set(v[0], safeParseFloat(v[1]));
});
}
requestResults[0].values.forEach((v: [number, string]) => {
const timestamp = new Date(v[0] * 1000).toLocaleTimeString();
const requestRate = safeParseFloat(v[1]);
const errorRate =
errorResults.length > 0 && errorResults[0].values[idx]
? safeParseFloat(errorResults[0].values[idx][1])
: 0;
const errorRate = errorByTimestamp.get(v[0]) ?? 0;

Comment on lines +402 to 414
snapshot.requestErrorData.push({
timestamp,
Expand Down
Loading