Skip to content

[test] add more coverage to HMAC key prop tests#339

Open
meilu-git wants to merge 2 commits intomainfrom
meilu/hmac_key_prop_test
Open

[test] add more coverage to HMAC key prop tests#339
meilu-git wants to merge 2 commits intomainfrom
meilu/hmac_key_prop_test

Conversation

@meilu-git
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands the HMAC key property integration tests (HKDF-derived HMAC keys) to cover more invalid/edge property combinations and a couple of additional “allowed” scenarios.

Changes:

  • Added small helper functions for deriving an ECDH base secret and deriving an HKDF-based HMAC key with custom props.
  • Added many new #[session_test] cases covering missing/invalid usage flags, invalid bit sizes, invalid classes, and property preservation checks.
  • Added explicit coverage for HKDF hash vs HMAC kind mismatch behavior.

Comment thread api/tests/src/algo/hmac/key_prop_tests.rs Outdated
Comment thread api/tests/src/algo/hmac/key_prop_tests.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants