Adding enable ultra ssd, eviction policy, and spot max price support for machine#9696
Adding enable ultra ssd, eviction policy, and spot max price support for machine#9696erinborders wants to merge 26 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @erinborders, |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @erinborders Release SuggestionsModule: aks-preview
Notes
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Could you add some unit tests? It would also be helpful to include a scenario test (e2e test) in test_aks_commands.py.
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change. Once test passed, please commit the recording file (find it from pipeline artifacts) to pass the CI check.
- test_aks_machine_add_spot_and_ultra_ssd
Please rebase from main to pick up the fix, cc @erinborders The CI |
…sions into erinborders/machine-preview
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…sions into erinborders/machine-preview
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Re-queued live test. Don't forget to commit the recording file after the live test has passed to ensure the CI checks are successful. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| } | ||
|
|
||
| def __init__(self, *, properties: Optional["_models.MachineProperties"] = None, **kwargs: Any) -> None: | ||
| def __init__(self, *, properties: Optional["_models.MachineProperties"] = None, zones: Optional[List[str]] = None, **kwargs: Any) -> None: |
There was a problem hiding this comment.
It's unusual to manually update the generated SDK. If zones aren't meant to be read-only, this should be adjusted in the API specification; otherwise, the change will be overwritten the next time the SDK is generated.
| operation_group="machines" | ||
| ) | ||
| machineBillingProfile = MachineBillingProfile( | ||
| spot_max_price=spot_max_price |
There was a problem hiding this comment.
the default value float("nan") is not standard in JSON
There was a problem hiding this comment.
oh I modeled this off of aks_agentpool_add which also has the spot_max_price property
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks machine add
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.