fix: relax k8s-extension pinned dependencies#9709
Conversation
|
Hi @eh8, |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
This PR updates the k8s-extension Azure CLI extension packaging metadata to relax two pinned third-party dependencies so that installs can resolve newer versions.
Changes:
- Relax
kubernetesdependency from==24.2.0to>=24.2.0 - Relax
orasdependency from==0.2.25to>=0.2.25
src/k8s-extension/setup.py
Outdated
| "kubernetes>=24.2.0", | ||
| "oras>=0.2.25", |
There was a problem hiding this comment.
The new dependency specifiers use unbounded lower ranges (e.g., kubernetes>=24.2.0, oras>=0.2.25). This can pull in future major (or for oras, even minor) releases that may introduce breaking API changes and cause the extension to fail at runtime. Consider using a compatible range with an upper bound (e.g., >=24.2.0,<25.0.0 / ~=24.2.0, and for oras something like >=0.2.25,<0.3.0) so installs remain predictable while still relaxing pins.
| "kubernetes>=24.2.0", | |
| "oras>=0.2.25", | |
| "kubernetes>=24.2.0,<25.0.0", | |
| "oras>=0.2.25,<0.3.0", |
src/k8s-extension/setup.py
Outdated
| "oras>=0.2.25", | ||
| ] | ||
|
|
||
| VERSION = "1.7.0" |
There was a problem hiding this comment.
Because this PR changes the published wheel’s dependency constraints, the extension version should be bumped and a corresponding entry added to HISTORY.rst. Keeping VERSION at 1.7.0 will make it difficult/impossible to publish a new build cleanly and makes it unclear to users that dependency behavior changed.
| VERSION = "1.7.0" | |
| VERSION = "1.7.1" |
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.