Skip to content

fix: relax k8s-extension pinned dependencies#9709

Open
eh8 wants to merge 2 commits intoAzure:mainfrom
eh8:patch-1
Open

fix: relax k8s-extension pinned dependencies#9709
eh8 wants to merge 2 commits intoAzure:mainfrom
eh8:patch-1

Conversation

@eh8
Copy link
Copy Markdown

@eh8 eh8 commented Mar 23, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings March 23, 2026 11:13
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @eh8,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 23, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the k8s-extension Azure CLI extension packaging metadata to relax two pinned third-party dependencies so that installs can resolve newer versions.

Changes:

  • Relax kubernetes dependency from ==24.2.0 to >=24.2.0
  • Relax oras dependency from ==0.2.25 to >=0.2.25

Comment on lines +34 to +35
"kubernetes>=24.2.0",
"oras>=0.2.25",
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new dependency specifiers use unbounded lower ranges (e.g., kubernetes>=24.2.0, oras>=0.2.25). This can pull in future major (or for oras, even minor) releases that may introduce breaking API changes and cause the extension to fail at runtime. Consider using a compatible range with an upper bound (e.g., >=24.2.0,<25.0.0 / ~=24.2.0, and for oras something like >=0.2.25,<0.3.0) so installs remain predictable while still relaxing pins.

Suggested change
"kubernetes>=24.2.0",
"oras>=0.2.25",
"kubernetes>=24.2.0,<25.0.0",
"oras>=0.2.25,<0.3.0",

Copilot uses AI. Check for mistakes.
"oras>=0.2.25",
]

VERSION = "1.7.0"
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this PR changes the published wheel’s dependency constraints, the extension version should be bumped and a corresponding entry added to HISTORY.rst. Keeping VERSION at 1.7.0 will make it difficult/impossible to publish a new build cleanly and makes it unclear to users that dependency behavior changed.

Suggested change
VERSION = "1.7.0"
VERSION = "1.7.1"

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 23, 2026

@yonzhan yonzhan assigned yanzhudd and unassigned zhoxing-ms Mar 23, 2026
@yonzhan yonzhan requested a review from yanzhudd March 23, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants