[AKS] add --gpu-mig-strategy option for aks nodepool add/update #9722
[AKS] add --gpu-mig-strategy option for aks nodepool add/update #9722yanzhudd merged 16 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @runzhen, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @runzhen Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Pull request overview
Adds support in the aks-preview extension for specifying a GPU MIG (Multi-Instance GPU) strategy when adding or updating AKS nodepools, and wires that option through the agentpool decorator into the SDK model.
Changes:
- Introduces
--gpu-mig-strategyargument (enum) foraz aks nodepool addandaz aks nodepool update. - Decorates/updates
agentpool.gpu_profile.nvidia.mig_strategyduring nodepool create/update flows. - Adds unit coverage for the context getter of
gpu_mig_strategyand CLI help text for nodepool add.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Adds getter + create/update wiring to set gpu_profile.nvidia.mig_strategy; adjusts managed GPU update behavior. |
| src/aks-preview/azext_aks_preview/_params.py | Adds the new CLI argument + enum list; modifies enable_managed_gpu argument registration. |
| src/aks-preview/azext_aks_preview/_help.py | Documents --gpu-mig-strategy in aks nodepool add help. |
| src/aks-preview/azext_aks_preview/_consts.py | Adds constants for MIG strategies (Single, Mixed). |
| src/aks-preview/azext_aks_preview/custom.py | Adds gpu_mig_strategy parameter to nodepool add/update custom handlers. |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Adds unit tests for get_gpu_mig_strategy() behavior. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hello @FumingZhang , do you know why the pipeline fails? I have merge the latest code from main branch |
|
The CI failed with this error @runzhen |
|
Hi @FumingZhang , I added the live test case, and excluded it in the json file, the test passed in my local. |
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @FumingZhang @yanzhudd , I rebased the code, can you review again? thanks |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @FumingZhang @yanzhudd I merged the main branch, but the pipeline still fails |
|
Hi @yanzhudd can you review it again? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
add --gpu-mig-strategy option for aks nodepool add/update
Related command
az aks nodepool add
az aks nodepool update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.