Skip to content

{AKS} Fix the location logic for managed namespace update#9723

Merged
yanzhudd merged 3 commits intoAzure:mainfrom
xmzhao0822:xmzhao/fix-bug-mns-update-location
Mar 26, 2026
Merged

{AKS} Fix the location logic for managed namespace update#9723
yanzhudd merged 3 commits intoAzure:mainfrom
xmzhao0822:xmzhao/fix-bug-mns-update-location

Conversation

@xmzhao0822
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks namespace update -g charlilirg --cluster-name charliliaks -n ns1 --annotations a=d --subscription c582d154-33c4-47e4-a3c2-0632d20b12eb

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings March 25, 2026 23:24
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Mar 25, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 25, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the managed namespace update request construction in aks-preview so that az aks namespace update uses the existing namespace resource’s location, and bumps the extension version/release notes accordingly.

Changes:

  • Update managed namespace update logic to set location from the existing namespace.
  • Bump aks-preview extension version to 19.0.0b28.
  • Add release note entry for the namespace update fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/aks-preview/azext_aks_preview/managednamespace.py Use existedNamespace.location during managed namespace update instead of looking up cluster location.
src/aks-preview/setup.py Version bump to 19.0.0b28.
src/aks-preview/HISTORY.rst Add 19.0.0b28 release notes entry for the change.

@yanzhudd yanzhudd merged commit cc6d0bd into Azure:main Mar 26, 2026
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aks-preview-19.0.0b28 ] : https://dev.azure.com/msazure/One/_build/results?buildId=158250273&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants