{AKS} Fix the location logic for managed namespace update#9723
{AKS} Fix the location logic for managed namespace update#9723yanzhudd merged 3 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the managed namespace update request construction in aks-preview so that az aks namespace update uses the existing namespace resource’s location, and bumps the extension version/release notes accordingly.
Changes:
- Update managed namespace update logic to set
locationfrom the existing namespace. - Bump
aks-previewextension version to19.0.0b28. - Add release note entry for the namespace update fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/aks-preview/azext_aks_preview/managednamespace.py |
Use existedNamespace.location during managed namespace update instead of looking up cluster location. |
src/aks-preview/setup.py |
Version bump to 19.0.0b28. |
src/aks-preview/HISTORY.rst |
Add 19.0.0b28 release notes entry for the change. |
|
[Release] Update index.json for extension [ aks-preview-19.0.0b28 ] : https://dev.azure.com/msazure/One/_build/results?buildId=158250273&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks namespace update -g charlilirg --cluster-name charliliaks -n ns1 --annotations a=d --subscription c582d154-33c4-47e4-a3c2-0632d20b12ebGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.