{AKS} Remove readOnly for nodeImageVersion#9742
Draft
FumingZhang wants to merge 2 commits intoAzure:mainfrom
Draft
{AKS} Remove readOnly for nodeImageVersion#9742FumingZhang wants to merge 2 commits intoAzure:mainfrom
FumingZhang wants to merge 2 commits intoAzure:mainfrom
Conversation
… rollback The TypeSpec conversion in Azure/azure-rest-api-specs#38641 incorrectly re-added readOnly to nodeImageVersion in agent pool models. This was intentionally removed in Azure/azure-rest-api-specs#37229 to enable agentpool rollback functionality. The upstream spec fix is tracked in Azure/azure-rest-api-specs#41598 but vendoring may take a week+. This is a temporary SDK-level workaround to unblock the rollback feature that is already in preview for customers. Removes readonly from nodeImageVersion in: - AgentPool - ManagedClusterAgentPoolProfileProperties - ManagedClusterAgentPoolProfile MachineProperties and Snapshot retain readonly as nodeImageVersion is genuinely read-only on those resources.
|
Hi @FumingZhang, |
️✔️Azure CLI Extensions Breaking Change Test
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
Contributor
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Contributor
|
Hi @FumingZhang Release SuggestionsModule: aks-preview
Notes
|
InduSridhar
pushed a commit
to InduSridhar/azure-cli-extensions
that referenced
this pull request
Mar 30, 2026
Per reviewer feedback (FumingZhang), in addition to removing readonly from _validation, the __init__ methods need to accept node_image_version as a parameter and assign it instead of hardcoding None. Without this, the serializer still cannot pass the value through during rollback. Changes for AgentPool, ManagedClusterAgentPoolProfileProperties, and ManagedClusterAgentPoolProfile (matching Azure#9742 pattern). MachineProperties and Snapshot are unchanged (genuinely read-only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
{AKS} Remove readOnly for nodeImageVersion
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.