aks-preview: Fix managedNATGatewayV2 outbound type being overwritten to loadBalancer by christine33-creator · Pull Request #9748 · Azure/azure-cli-extensions

christine33-creator · 2026-03-31T22:57:54Z

The dynamic completion logic in _get_outbound_type() did not include managedNATGatewayV2 in its list of known outbound types. When a user specified --outbound-type managedNATGatewayV2, the CLI treated it as an unrecognized value and silently overwrote it to loadBalancer before sending the request to the RP.

Fixed in 3 places:

Dynamic completion list: preserve managedNATGatewayV2 instead of overwriting to loadBalancer
Basic LB SKU validation: reject managedNATGatewayV2 with basic SKU
Multi-zone warning: show zone-redundancy warning for V2 on update

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-03-31T22:57:59Z

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

azure-client-tools-bot-prd · 2026-03-31T22:58:02Z

Hi @christine33-creator,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2026-03-31T22:58:20Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-03-31T22:58:24Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-03-31T22:59:22Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions · 2026-03-31T23:02:18Z

Hi @christine33-creator

Release Suggestions

Module: aks-preview

Update VERSION to 19.0.0b29 in src/aks-preview/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull request overview

Fixes an aks-preview regression where managedNATGatewayV2 was treated as an unknown outbound type during _get_outbound_type() dynamic completion, causing it to be silently overwritten to loadBalancer before the request was sent to the RP.

Changes:

Add managedNATGatewayV2 to the “known outbound types” list so it is preserved (not defaulted to loadBalancer) during create-time dynamic completion.
Extend outbound-type validation to reject managedNATGatewayV2 when using Basic load balancer SKU.
Extend the multi-zone NAT Gateway update warning to also apply to managedNATGatewayV2.

Copilot · 2026-03-31T23:04:42Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

        if (
            self.decorator_mode == DecoratorMode.CREATE and
            not read_from_mc and
            outbound_type not in [
                CONST_OUTBOUND_TYPE_MANAGED_NAT_GATEWAY,
+                CONST_OUTBOUND_TYPE_MANAGED_NAT_GATEWAY_V2,
                CONST_OUTBOUND_TYPE_USER_ASSIGNED_NAT_GATEWAY,


Consider adding/adjusting unit tests to cover the regression fixed here: when the user explicitly sets --outbound-type managedNATGatewayV2, _get_outbound_type() should preserve it (not default to loadBalancer), and enable_validation should reject it when load balancer SKU is basic. There are existing unit tests for _get_outbound_type() but none exercise the V2 outbound type path.

FumingZhang

Is there an existing test case that covers this scenario to confirm the fix is correct? If not, please create one and schedule the live test to ensure it works as expected.

christine33-creator · 2026-04-01T02:33:14Z

Is there an existing test case that covers this scenario to confirm the fix is correct? If not, please create one and schedule the live test to ensure it works as expected.

Added a unit test in test_managed_cluster_decorator.py that verifies managedNATGatewayV2 is preserved through the dynamic completion logic instead of being overwritten to loadBalancer.

The test passes locally. A live test cannot pass yet because the RP-side feature toggle is not enabled; the RP currently returns UnsupportedOutboundType across all tested regions (eastus2, westus2, eastus2euap, centraluseuap). We can add/schedule the live test once the RP rollout begins.

FumingZhang · 2026-04-01T02:41:15Z

/azp run

azure-pipelines · 2026-04-01T02:41:27Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang

lgtm

Please leave a note about the fix in HISTORY.rst

levimm · 2026-04-01T06:35:14Z

src/aks-preview/HISTORY.rst

@@ -13,6 +13,7 @@ Pending
 +++++++


bump the version to 19.0.0b29?

…to loadBalancer The dynamic completion logic in _get_outbound_type() did not include managedNATGatewayV2 in its list of known outbound types. When a user specified --outbound-type managedNATGatewayV2, the CLI treated it as an unrecognized value and silently overwrote it to loadBalancer before sending the request to the RP. Fixed in 3 places: - Dynamic completion list: preserve managedNATGatewayV2 instead of overwriting to loadBalancer - Basic LB SKU validation: reject managedNATGatewayV2 with basic SKU - Multi-zone warning: show zone-redundancy warning for V2 on update

azure-client-tools-bot-prd bot added this to the May 2026 (2026-05-05) milestone Mar 31, 2026

christine33-creator changed the title ~~aks-preview: Fix managedNATGatewayV2 outbound type being overwritten …~~ aks-preview: Fix managedNATGatewayV2 outbound type being overwritten to loadBalancer Mar 31, 2026

microsoft-github-policy-service bot requested review from FumingZhang, yanzhudd, yonzhan and zhoxing-ms March 31, 2026 23:00

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Mar 31, 2026

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Mar 31, 2026

christine33-creator marked this pull request as ready for review March 31, 2026 23:01

christine33-creator requested a review from andyliuliming as a code owner March 31, 2026 23:01

Copilot AI review requested due to automatic review settings March 31, 2026 23:01

Copilot started reviewing on behalf of christine33-creator March 31, 2026 23:02 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

FumingZhang reviewed Apr 1, 2026

View reviewed changes

yonzhan unassigned zhoxing-ms Apr 1, 2026

christine33-creator force-pushed the cdossa/fix-natgatewayv2-outbound-type branch from 6aff0ee to 14d28f4 Compare April 1, 2026 02:25

FumingZhang reviewed Apr 1, 2026

View reviewed changes

christine33-creator force-pushed the cdossa/fix-natgatewayv2-outbound-type branch from 14d28f4 to eb73cb3 Compare April 1, 2026 04:08

levimm reviewed Apr 1, 2026

View reviewed changes

christine33-creator force-pushed the cdossa/fix-natgatewayv2-outbound-type branch from eb73cb3 to 3a4a9b0 Compare April 1, 2026 16:14

Conversation

christine33-creator commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Mar 31, 2026

Uh oh!

yonzhan commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

CodeGen Tools Feedback Collection

Uh oh!

github-actions bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Suggestions

Module: aks-preview

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

christine33-creator commented Apr 1, 2026

Uh oh!

FumingZhang commented Apr 1, 2026

Uh oh!

azure-pipelines bot commented Apr 1, 2026

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

levimm Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

christine33-creator Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

christine33-creator commented Mar 31, 2026 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 31, 2026 •

edited

Loading

github-actions bot commented Mar 31, 2026 •

edited

Loading