[PostgreSQL] az postgres flexible-server server-logs list: Fix 33090, command crashes with an AttributeError when listing log files#33096
Open
nachoalonsoportillo wants to merge 6 commits intoAzure:devfrom
Conversation
… removing created_time attributes
nachoalonsoportillo
requested review from
Pan-Qi,
VeryEarly and
calvinhzy
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @nachoalonsoportillo, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Member
Author
|
Fixes #33090. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PostgreSQL flexible-server server logs listing implementation to sanitize captured log file objects before returning them, specifically to remove created_time-related fields that are causing SDK compatibility issues.
Changes:
- Added
_sanitize_log_file()helper to convert log file objects into dictionaries and recursively removecreated_timevariants. - Updated
flexible_server_list_log_files_with_filterandflexible_server_log_listto return sanitized log file dictionaries instead of mutating SDK objects.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/postgresql/commands/server_logs_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/postgresql/commands/server_logs_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/postgresql/commands/server_logs_commands.py
Show resolved
Hide resolved
nachoalonsoportillo
changed the title
az postgres flexible-server server-logs list: BUG FIX, command crashes with an AttributeError when listing log files
…jects for SDK compatibility
…es for SDK compatibility
nachoalonsoportillo
modified the milestones:
May 2026 (2026-05-05),
April 2026 (2026-04-07)
…og file generation wait logic - Removed the conditional return for live tests. - Combined the environment variable check with the sleep function to streamline the waiting period for log file generation.
nasc17
approved these changes
Mar 30, 2026
Member
|
@calvinhzy and @yonzhan please trigger checks |
nasc17
approved these changes
Mar 30, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nachoalonsoportillo
changed the title
az postgres flexible-server server-logs list: BUG FIX, command crashes with an AttributeError when listing log filesaz postgres flexible-server server-logs list: Fix 33090, command crashes with an AttributeError when listing log files
Member
|
@calvinhzy and @yonzhan please trigger checks, fix we put in for the title, and we needed this for the April release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
az postgres flexible-server server-logs listcrashes with an AttributeError when listing log files.Here are the significant differences between LogFile (old) and CapturedLog (new):
Field changes
Read-only enforcement
In the old SDK, created_time and last_modified_time were declared readonly: True in _validation — i.e., server-side only. In the new SDK, both are declared with full CRUD visibility (["read", "create", "update", "delete", "query"]), removing the hard read-only constraint at the SDK layer.
SDK generation style
The old SDK was AutoRest-generated (_serialization.Model, _validation, _attribute_map dicts). The new SDK uses the Python Code Generator (_Model, rest_field, @overload constructors). This changes how serialization and validation are expressed, though the wire format is the same.
For now, let's fix it like this. My proposal is to also add a deprecation note to inform that shape of returned object will change in the future to, at least, surface createdTime. We could also consider renaming typePropertiestype to something like logType.
Testing Guide
I noticed that the existing tests weren't running the `server-logs list' command when live test was run. That would have caught the error before we would have merged the PR that introduced the offending SDK. So, I've enable it and refreshed the recordings.
History Notes
[PostgreSQL]
az postgres flexible-server server-logs list: Fix 33090, command crashes with an AttributeError when listing log filesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.