-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{Misc.} Updated SyncSquadMapping script #33108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+27
−3
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b2f5c27
added changes for squad mapping
a0x1ab e5d6000
Merge branch 'Azure:dev' into dev
a0x1ab dc3413e
added changes per suggestion
a0x1ab 6658691
Merge branch 'dev' of https://github.com/a0x1ab/azure-cli into dev
a0x1ab 83a4013
Merge branch 'Azure:dev' into dev
a0x1ab c328cdd
updated parsing file
a0x1ab d8dda2e
Merge branch 'dev' of https://github.com/a0x1ab/azure-cli into dev
a0x1ab 62d4592
updated parse squad mapping list script
a0x1ab c007286
Merge branch 'Azure:dev' into dev
a0x1ab 9f14a20
Merge branch 'Azure:dev' into dev
a0x1ab 40b45b0
added changes to mention teams, change assignment to reviewer for squads
a0x1ab 1151cc7
Merge branch 'Azure:dev' into dev
a0x1ab 264db8d
fix small errors in indentation
a0x1ab cb81937
Merge branch 'dev' of https://github.com/a0x1ab/azure-cli into dev
a0x1ab 1255760
Merge branch 'Azure:dev' into dev
a0x1ab 0784be5
Merge branch 'Azure:dev' into dev
a0x1ab e337455
Merge branch 'Azure:dev' into dev
a0x1ab 9980b84
Added new rules to resourceManagemnt.yml
a0x1ab 542986e
Merge branch 'Azure:dev' into dev
a0x1ab 4576d81
added new issues ruleset
a0x1ab 4939d37
Merge branch 'dev' of https://github.com/a0x1ab/azure-cli into dev
a0x1ab 2bdfeab
Merge branch 'Azure:dev' into dev
a0x1ab 469eaaf
updated mentionee logic
a0x1ab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback for computing $mentionItemIndent treats $mentioneesIndent==0 as "unset" because it checks
-gt 0. If amentionees:block is ever at column 0 (valid YAML), this will choose($listIndentLength + 4)and insert mis-indented mentionees, potentially breaking YAML parsing. Consider using-ge 0(or initialize to $null and test for$null -ne $mentioneesIndent) so an indent of 0 is handled correctly.