Skip to content

[ServiceBus] FIXING ISO TYPO: 8061 to 8601 #33118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
william-keller wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[ServiceBus] FIXING ISO TYPO: 8061 to 8601 #33118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/servicebus/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from knack.util import CLIError

# PARAMETER VALIDATORS
# Type ISO 8061 duration
# Type ISO 8601 duration

iso8601pattern = re.compile("^P(?!$)(\\d+Y)?(\\d+M)?(\\d+W)?(\\d+D)?(T(?=\\d)(\\d+H)?(\\d+M)?(\\d+.)?(\\d+S)?)?$")
timedeltapattern = re.compile("^\\d+:\\d+:\\d+$")
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/queue/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.auto_delete_on_idle = AAZDurationArg(
options=["--auto-delete-on-idle"],
arg_group="Properties",
help="ISO 8061 timeSpan idle interval after which the queue is automatically deleted. The minimum duration is 5 minutes.",
help="ISO 8601 timeSpan idle interval after which the queue is automatically deleted. The minimum duration is 5 minutes.",
)
_args_schema.enable_dead_lettering_on_message_expiration = AAZBoolArg(
options=["--message-expiration", "--enable-dead-lettering-on-message-expiration"],
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/queue/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.auto_delete_on_idle = AAZDurationArg(
options=["--auto-delete-on-idle"],
arg_group="Properties",
help="ISO 8061 timeSpan idle interval after which the queue is automatically deleted. The minimum duration is 5 minutes.",
help="ISO 8601 timeSpan idle interval after which the queue is automatically deleted. The minimum duration is 5 minutes.",
nullable=True,
)
_args_schema.enable_dead_lettering_on_message_expiration = AAZBoolArg(
Expand Down
6 changes: 3 additions & 3 deletions .../azure/cli/command_modules/servicebus/aaz/latest/servicebus/topic/subscription/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.auto_delete_on_idle = AAZDurationArg(
options=["--auto-delete-on-idle"],
arg_group="Properties",
help="ISO 8061 timeSpan idle interval after which the topic is automatically deleted. The minimum duration is 5 minutes.",
help="ISO 8601 timeSpan idle interval after which the topic is automatically deleted. The minimum duration is 5 minutes.",
)
_args_schema.dead_letter_on_filter_exceptions = AAZBoolArg(
options=["-f", "--dead-letter-on-filter-exceptions"],
Expand All @@ -111,7 +111,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.default_message_time_to_live = AAZDurationArg(
options=["--default-message-time-to-live"],
arg_group="Properties",
help="ISO 8061 Default message timespan to live value. This is the duration after which the message expires, starting from when the message is sent to Service Bus. This is the default value used when TimeToLive is not set on a message itself.",
help="ISO 8601 Default message timespan to live value. This is the duration after which the message expires, starting from when the message is sent to Service Bus. This is the default value used when TimeToLive is not set on a message itself.",
)
_args_schema.duplicate_detection_history_time_window = AAZDurationArg(
options=["-d", "--duplicate-detection-history-time-window"],
Expand Down Expand Up @@ -141,7 +141,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.lock_duration = AAZDurationArg(
options=["--lock-duration"],
arg_group="Properties",
help="ISO 8061 lock duration timespan for the subscription. The default value is 1 minute.",
help="ISO 8601 lock duration timespan for the subscription. The default value is 1 minute.",
)
_args_schema.max_delivery_count = AAZIntArg(
options=["--max-delivery-count"],
Expand Down
6 changes: 3 additions & 3 deletions .../azure/cli/command_modules/servicebus/aaz/latest/servicebus/topic/subscription/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.auto_delete_on_idle = AAZDurationArg(
options=["--auto-delete-on-idle"],
arg_group="Properties",
help="ISO 8061 timeSpan idle interval after which the topic is automatically deleted. The minimum duration is 5 minutes.",
help="ISO 8601 timeSpan idle interval after which the topic is automatically deleted. The minimum duration is 5 minutes.",
nullable=True,
)
_args_schema.dead_letter_on_filter_exceptions = AAZBoolArg(
Expand All @@ -122,7 +122,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.default_message_time_to_live = AAZDurationArg(
options=["--default-message-time-to-live"],
arg_group="Properties",
help="ISO 8061 Default message timespan to live value. This is the duration after which the message expires, starting from when the message is sent to Service Bus. This is the default value used when TimeToLive is not set on a message itself.",
help="ISO 8601 Default message timespan to live value. This is the duration after which the message expires, starting from when the message is sent to Service Bus. This is the default value used when TimeToLive is not set on a message itself.",
nullable=True,
)
_args_schema.duplicate_detection_history_time_window = AAZDurationArg(
Expand Down Expand Up @@ -158,7 +158,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
_args_schema.lock_duration = AAZDurationArg(
options=["--lock-duration"],
arg_group="Properties",
help="ISO 8061 lock duration timespan for the subscription. The default value is 1 minute.",
help="ISO 8601 lock duration timespan for the subscription. The default value is 1 minute.",
nullable=True,
)
_args_schema.max_delivery_count = AAZIntArg(
Expand Down
Loading