-
Notifications
You must be signed in to change notification settings - Fork 332
fix(agents): resolve project root for infra eject #9291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hund030
wants to merge
7
commits into
main
Choose a base branch
from
fix/agents-adopt-infra-eject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−37
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5fa5063
fix(agents): eject infra after adopting unified manifest
hund030 43ba570
fix(agents): resolve project root for infra eject
hund030 41e948c
test(agents): restrict infra test directory permissions
hund030 db9d0e9
fix(agents): propagate infra eject validation errors
hund030 865ff7b
test(agents): cover post-init eject without Foundry
hund030 9e443da
Potential fix for pull request finding
hund030 976d2f2
test(agents): format stdout capture
hund030 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is the fix for scenario 3 in #9287 (standalone eject from a subdirectory), and nothing covers it.
I reverted it locally to
fileExists("azure.yaml")plusos.Getwd()and ran the whole package:ok azureaiagent/internal/cmd. The four newTestEjectInfraAfterInit_*tests all callejectInfraAfterInitdirectly, which is what the post-init paths use, so none of them reach this code.This isn't the same situation as the bare-definition and unified-manifest branches I said needed a mock azd gRPC server. This one returns on line 1142, before
azdext.NewAzdClient()on line 1148, so there's no client, no prompting, and no network. Driving the real cobra command covers it:Passes at 976d2f2 in 0.11s. With the old cwd-only lookup it fails, because the command falls through into the interactive init flow instead of ejecting. The passing path never reaches the azd client, so it stays hermetic.