[bugfix]: Fixes datetime parsing for all nulls data#621
Open
[bugfix]: Fixes datetime parsing for all nulls data#621
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a pandas 3.0 compatibility issue where dataframe_from_result_table fails when processing columns with all null datetime values. The fix removes dead code that was checking for pandas version 1.x compatibility, since the minimum supported pandas version is 2.3.1.
Changes:
- Simplified
parse_datetimefunction by removing pandas version checks and string manipulation logic - Updated
test_datetime_parsingto remove tests for the obsoleteforce_versionparameter - Added new test
test_all_null_datetime_columnto verify the fix for issue #620
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| azure/kusto/data/helpers.py | Simplified parse_datetime by removing pandas 1.x compatibility code and force_version parameter |
| tests/test_helpers.py | Removed force_version tests and added regression test for all-null datetime columns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed dead code for pandas version check, as the min pandas version required is 2.3.1
Added
Changed
Fixed
#620