Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Summary

Added managedByExtended to the list of allowed body top-level properties for ARM resources in compliance with ARM guidelines.

Changes Made

Code Changes

  • ✅ Updated allowedBodyTopLevelProperties array in arm-resource-validation.ts to include managedbyextended
  • ✅ Updated propertiesBagTracked array in arm-resource-validation.ts to include managedbyextended
  • ✅ Updated error message to list all allowed properties: name, type, id, location, properties, tags, plan, sku, etag, managedBy, managedByExtended, identity, kind, zones, systemData, extendedLocation

Documentation Changes

  • ✅ Updated body-top-level-properties.md to include managedByExtended and all properties
  • ✅ Updated rules.md to include managedByExtended and all properties
  • ✅ Fixed casing inconsistencies (extendedLocation)

Testing

  • ✅ Updated existing test file body-top-level-properties-real-swagger.json to include managedByExtended property
  • ✅ Removed separate test file to consolidate test cases
  • ✅ All tests pass successfully (438 spectral tests + 90 native tests)
  • ✅ Build and lint checks pass

Package Management

  • ✅ Bumped package version to 2.2.2 in package.json
  • ✅ Updated CHANGELOG.md with version 2.2.2 entry for this change

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 5 commits January 27, 2026 20:37
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Copilot AI changed the title [WIP] Update allowedBodyTopLevelProperties to include managedByExtended Add managedByExtended to allowed ARM resource top-level properties Jan 27, 2026
Copilot AI requested a review from raosuhas January 27, 2026 20:49
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot instead of creating a new json file for the test , can you just update one of the existing files to include these tests ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! I've added the managedByExtended property to the existing body-top-level-properties-real-swagger.json file instead of creating a new test file. The separate test file has been removed and the test case now uses the updated existing file. All tests pass. (commit 90d4543)

…tended

Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Copilot AI requested a review from raosuhas January 27, 2026 22:12
@mikeharder
Copy link
Member

@copilot: update the package.json and changelog associated with this package

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot: update the package.json and changelog associated with this package

Added Rush change file for version tracking. The change file will automatically bump the patch version and update the changelog when the next release is published. (commit cab0d67)

@mikeharder
Copy link
Member

@copilot: update the package.json and changelog associated with this package

Added Rush change file for version tracking. The change file will automatically bump the patch version and update the changelog when the next release is published. (commit cab0d67)

@copilot: Actually, we directly update package.json and readme.md now, instead of using rush. See PR #783 as an example. For this PR, bump the patch version by one.

@mikeharder
Copy link
Member

@copilot: update the package.json and changelog associated with this package

Added Rush change file for version tracking. The change file will automatically bump the patch version and update the changelog when the next release is published. (commit cab0d67)

@copilot: Why did you think you needed to use Rush to update this? Was it some documentation in the repo?

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot: update the package.json and changelog associated with this package

Added Rush change file for version tracking. The change file will automatically bump the patch version and updat...

Updated! Removed the Rush change file and directly updated package.json (bumped version from 2.2.0 to 2.2.1) and CHANGELOG.md with the new patch version entry. (commit 5cb9e21)

Copy link
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot: update the package.json and changelog associated with this package

Added Rush change file for version tracking. The change file will automatically bump the patch version and updat...

Yes, the CONTRIBUTING.md documentation (lines 105-107) instructs to "Run rush change to generate changelog" and states "If you don't add the right entries, the CI build will fail." This guidance led me to initially use Rush change files.

@mikeharder mikeharder changed the title Add managedByExtended to allowed ARM resource top-level properties [BodyTopLevelProperties] Add "managedByExtended" to allowed list of top-level properties Jan 29, 2026
@mikeharder
Copy link
Member

@copilot: increment the patch version by one

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 30, 2026

@copilot: increment the patch version by one

Updated! Incremented patch version from 2.2.1 to 2.2.2 in package.json and updated CHANGELOG.md to separate the two patches (2.2.2 for managedByExtended, 2.2.1 for MutabilityWithReadOnly). (commit ad0471d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants