-
Notifications
You must be signed in to change notification settings - Fork 50
[BodyTopLevelProperties] Add "managedByExtended" to allowed list of top-level properties #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot instead of creating a new json file for the test , can you just update one of the existing files to include these tests ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! I've added the managedByExtended property to the existing body-top-level-properties-real-swagger.json file instead of creating a new test file. The separate test file has been removed and the test case now uses the updated existing file. All tests pass. (commit 90d4543)
…tended Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
|
@copilot: update the package.json and changelog associated with this package |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
@copilot: Actually, we directly update package.json and readme.md now, instead of using rush. See PR #783 as an example. For this PR, bump the patch version by one. |
@copilot: Why did you think you needed to use Rush to update this? Was it some documentation in the repo? |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Updated! Removed the Rush change file and directly updated package.json (bumped version from 2.2.0 to 2.2.1) and CHANGELOG.md with the new patch version entry. (commit 5cb9e21) |
Yes, the CONTRIBUTING.md documentation (lines 105-107) instructs to "Run |
|
@copilot: increment the patch version by one |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Summary
Added
managedByExtendedto the list of allowed body top-level properties for ARM resources in compliance with ARM guidelines.Changes Made
Code Changes
allowedBodyTopLevelPropertiesarray in arm-resource-validation.ts to includemanagedbyextendedpropertiesBagTrackedarray in arm-resource-validation.ts to includemanagedbyextendedDocumentation Changes
Testing
body-top-level-properties-real-swagger.jsonto include managedByExtended propertyPackage Management
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.