[PS] Migrate DnsResolver module to autorest v4 by JoyerJin · Pull Request #28695 · Azure/azure-powershell

JoyerJin · 2025-10-15T06:44:55Z

Description

Preannouncement PR:

[PS] DnsReolver module migration autorest v4 breaking change announcement #28698
[Az.DnsResolver] Add breaking change announcements for 2025-10-01-preview API migration #29308

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2025-10-15T06:44:59Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

github-actions · 2026-01-09T04:41:59Z

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

According to our policy, breaking changes can only take place during major release and they must be preannounced.
Please follow our guide on the detailed steps.
Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

JiaSeng-v · 2026-01-13T07:00:26Z

/azp run

azure-pipelines · 2026-01-13T07:00:52Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

This pull request migrates the DnsResolver module from AutoRest v3 to AutoRest v4, introducing new features available in the updated code generator. The changes primarily involve regenerated help documentation, breaking change exception tracking, and minor namespace updates.

Changes:

Upgraded help documentation with new parameter sets and corrected SYNOPSIS descriptions across all cmdlets
Added breaking change exceptions CSV file to track API compatibility issues introduced by the migration
Updated module manifest dependencies and metadata
Modified namespace references from Api20230701Preview to simplified model namespaces

Reviewed changes

Copilot reviewed 188 out of 188 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/DnsResolver/DnsResolver/ChangeLog.md	Added entry documenting AutoRest v4 upgrade
src/DnsResolver/DnsResolver/Az.DnsResolver.psd1	Updated Az.Accounts dependency, generation date, and formatting
tools/StaticAnalysis/Exceptions/Az.DnsResolver/BreakingChangeIssues.csv	New file tracking 82 breaking changes from AutoRest migration
src/DnsResolver/DnsResolver/help/*.md	Updated SYNOPSIS from "Creates/Updates" to "Create/Update" and added new parameter sets
src/DnsResolver/DnsResolver.Autorest/docs/*.md	Similar help updates with parameter set additions
src/DnsResolver/DnsResolver.sln	Updated project GUID
src/DnsResolver/DnsResolver.Autorest/generate-info.json	Updated generation ID
src/DnsResolver/DnsResolver.Autorest/custom/csharp/*.cs	Updated namespace from Api20230701Preview to simplified Models

isra-fel · 2026-01-13T08:09:18Z

/azp run

azure-pipelines · 2026-01-13T08:09:33Z

Azure Pipelines successfully started running 3 pipeline(s).

jamesvoongms · 2026-02-10T17:26:02Z

Thanks @JoyerJin, I am on the private resolver team and will re-record the tests for the PR

jamesvoongms · 2026-03-24T17:12:43Z

As mentioned in email, I have added the re-recorded tests in #29285

The PR above must also be released in the same version as this as we were previously using a preview branch and main is missing these changes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

NoriZC · 2026-03-25T07:08:41Z

/azp run

azure-pipelines · 2026-03-25T07:09:00Z

Azure Pipelines successfully started running 3 pipeline(s).

jamesvoongms · 2026-03-26T00:27:33Z

Please also wait on breaking change annoucement merge: #29308

…igrate-v4

JunKai-v · 2026-04-07T08:23:34Z

/azp run

azure-pipelines · 2026-04-07T08:23:50Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 204 out of 297 changed files in this pull request and generated 20 comments.

Copilot · 2026-04-07T08:33:45Z

+* Upgraded API version from 2023-07-01-preview to 2025-10-01-preview
+* Added new cmdlet `Invoke-AzDnsResolverBulkDnsResolverDomainList`
+* Introduced various new features by upgrading code generator. Please see details [here](https://github.com/Azure/azure-powershell/blob/main/documentation/Autorest-powershell-v4-new-features.md).
+* [Breaking Change] Removed parameter `ActionBlockResponseCode` from `New-AzDnsResolverPolicyDnsSecurityRule` and `Update-AzDnsResolverPolicyDnsSecurityRule`. The block response code is no longer configurable.
+* [Breaking Change] Parameter `DnsResolverDomainList` is no longer mandatory on `New-AzDnsResolverPolicyDnsSecurityRule`. DNS security rules now support `ManagedDomainList` as an alternative.
+* [Breaking Change] Parameter `Domain` is no longer mandatory on `New-AzDnsResolverDomainList`. Domain lists now support bulk upload via `Invoke-AzDnsResolverBulkDnsResolverDomainList`.


Changelog entries under "## Upcoming Release" should reference the related GitHub issue/PR numbers (for traceability) and be phrased for Azure PowerShell users. Consider adding references such as [#28698] / [#29308] to the migration + breaking-change bullets, and rewording the generator-upgrade line to describe the user-visible impact rather than the implementation detail.

Copilot · 2026-04-07T08:33:46Z

 ### -VirtualNetworkName
-The name of the virtual network.
+The name of the VirtualNetwork


The parameter description uses inconsistent casing/wording: "The name of the VirtualNetwork" reads like a type name. Please change this to a user-facing phrase such as "The name of the virtual network."

Copilot · 2026-04-07T08:33:46Z

 ### -VirtualNetworkName
-The name of the virtual network.
+The name of the VirtualNetwork



The parameter description uses inconsistent casing/wording: "The name of the VirtualNetwork" reads like a type name. Please change this to a user-facing phrase such as "The name of the virtual network."

Copilot · 2026-04-07T08:33:46Z

 ### -VirtualNetworkName
-The name of the virtual network.
+The name of the VirtualNetwork



The parameter description uses inconsistent casing/wording: "The name of the VirtualNetwork" reads like a type name. Please change this to a user-facing phrase such as "The name of the virtual network."

Copilot · 2026-04-07T08:33:47Z

 ### -Domain
 The domains in the domain list.
+Will be null if user is using large domain list.



"Will be null if user is using large domain list." is unclear/grammatically incorrect for help content. Consider rephrasing to explain when users should omit -Domain (for example, when using the bulk upload cmdlet) rather than describing the property value as null.

Copilot · 2026-04-07T08:33:50Z

+    It 'Delete a domain list' {
+        Remove-AzDnsResolverDomainList -Name "domainlist-rm-1" -ResourceGroupName $rgName
+        { Get-AzDnsResolverDomainList -Name "domainlist-rm-1" -ResourceGroupName $rgName } | Should -Throw


Remove-AzDnsResolverDomainList is called without disabling confirmation. Because this is a destructive cmdlet, it may prompt in non-interactive test runs and hang the suite. Please pass -Confirm:$false (or -Force if supported) in tests.

Copilot · 2026-04-07T08:33:50Z

+    AfterAll {
+        if ($TestMode -ne 'playback') { Remove-AzResourceGroup -Name $rgName -ErrorAction SilentlyContinue -AsJob | Out-Null }
+    }


Remove-AzResourceGroup is invoked without -Force/-Confirm:$false. In non-interactive test runs this can block on confirmation prompts and cause the test job to hang. Please add -Force (or explicitly disable confirmation) and consider waiting for the async job to complete (or avoid -AsJob) so resource cleanup is deterministic.

Copilot · 2026-04-07T08:33:50Z

+    It 'Delete a security rule' {
+        Remove-AzDnsResolverPolicyDnsSecurityRule -Name "secrule-rm-1" -DnsResolverPolicyName "policy-secrule-r" -ResourceGroupName $rgName
+        { Get-AzDnsResolverPolicyDnsSecurityRule -Name "secrule-rm-1" -DnsResolverPolicyName "policy-secrule-r" -ResourceGroupName $rgName } | Should -Throw


Remove-AzDnsResolverPolicyDnsSecurityRule is called without disabling confirmation. Because this is a destructive cmdlet, it may prompt in non-interactive test runs and hang the suite. Please pass -Confirm:$false (or -Force if supported) in tests.

Copilot · 2026-04-07T08:33:50Z

+    AfterAll {
+        if ($TestMode -ne 'playback') {
+            Remove-AzResourceGroup -Name $rgName -ErrorAction SilentlyContinue -AsJob | Out-Null
        }


Remove-AzResourceGroup is invoked without -Force/-Confirm:$false. In non-interactive test runs this can block on confirmation prompts and cause the test job to hang. Please add -Force (or explicitly disable confirmation) and consider waiting for the async job to complete (or avoid -AsJob) so resource cleanup is deterministic.

Copilot · 2026-04-07T08:33:51Z

+        New-AzDnsResolver -Name "resolver-rm-1" -ResourceGroupName $rgName -VirtualNetworkId $vnetId -Location $location
+        Remove-AzDnsResolver -Name "resolver-rm-1" -ResourceGroupName $rgName



Remove-AzDnsResolver is called without disabling confirmation. Because this is a destructive cmdlet, it may prompt in non-interactive test runs and hang the suite. Please pass -Confirm:$false (or -Force if supported) in tests.

jamesvoongms · 2026-04-09T16:32:44Z

/azp run

azure-pipelines · 2026-04-09T16:32:53Z

Commenter does not have sufficient privileges for PR 28695 in repo Azure/azure-powershell

jamesvoongms · 2026-04-09T21:30:16Z

I can't seem to approve this PR but I have ran the tests again myself using the built module and everything is working as expected, signing off from Managed Resolver team

Migrate DnsResolver module to autorest v4

817482d

Create BreakingChangeIssues.csv

baf25cd

Pan-Qi added Contains Breaking Change This PR contains breaking change autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 labels Jan 9, 2026

[Az.DnsResolver] fix merge conflict

bb044f8

[Az.DnsResolver] rebuild

728446a

Copilot AI review requested due to automatic review settings January 13, 2026 07:40

Copilot started reviewing on behalf of JiaSeng-v January 13, 2026 07:43 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

JiaSeng-v marked this pull request as ready for review January 14, 2026 00:05

isra-fel assigned Pan-Qi Jan 28, 2026

isra-fel added this to the Az 16.0.0 (TBD) milestone Jan 28, 2026

Dev/jamesvoong/dnsresolver v4 preview (#29285)

ec0fd4c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JunKai-v added 2 commits April 7, 2026 16:09

Merge remote-tracking branch 'upstream/main' into joyer/dnsresolver-m…

e0ab83c

…igrate-v4

rebuild

a345c32

Copilot AI review requested due to automatic review settings April 7, 2026 08:22

Copilot started reviewing on behalf of JunKai-v April 7, 2026 08:24 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

		New-AzDnsResolver -Name "resolver-rm-1" -ResourceGroupName $rgName -VirtualNetworkId $vnetId -Location $location
		Remove-AzDnsResolver -Name "resolver-rm-1" -ResourceGroupName $rgName

Conversation

JoyerJin commented Oct 15, 2025 • edited by JunKai-v Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

JiaSeng-v commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

isra-fel commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

jamesvoongms commented Feb 10, 2026

Uh oh!

jamesvoongms commented Mar 24, 2026

Uh oh!

NoriZC commented Mar 25, 2026

Uh oh!

azure-pipelines bot commented Mar 25, 2026

Uh oh!

jamesvoongms commented Mar 26, 2026

Uh oh!

JunKai-v commented Apr 7, 2026

Uh oh!

azure-pipelines bot commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

jamesvoongms commented Apr 9, 2026

Uh oh!

azure-pipelines bot commented Apr 9, 2026

Uh oh!

jamesvoongms commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

JoyerJin commented Oct 15, 2025 •

edited by JunKai-v

Loading