-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Dev/bhbrahma/gallery managed identity #29381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
D1v38om83r
wants to merge
21
commits into
Azure:main
Choose a base branch
from
D1v38om83r:dev/bhbrahma/galleryManagedIdentity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5baca89
Initial plan
Copilot 90fef0c
Add managed identity support to New-AzGallery and Update-AzGallery cm…
Copilot 022079f
Merge branch 'copilot/az-compute-gallery-managed-identity' of https:/…
D1v38om83r d110540
added tet file for Test-GalleryWithSystemAssignedIdentity
D1v38om83r 7dcdc7d
added test recording for Test-UpdateGalleryWithSystemAssignedIdentity
D1v38om83r c5d854f
added TestGalleryWithUserAssignedIdentity with recording
D1v38om83r 8fc776b
fixed Update-AzGallery -UserAssignedIdentity behavior
D1v38om83r 00456ac
added test for Update-AzGallery -EnableSystemAssignedIdentity -UserAs…
D1v38om83r af20c04
added Test-GalleryWithSystemAndUserAssignedIdentity and recording
D1v38om83r 4c9c3f0
Intriduced parameters -DisableSystemAssignedIdentity -RemoveAllUserAs…
D1v38om83r 10a144b
updated changelog.md
D1v38om83r 3e08d35
re-recorded test files
D1v38om83r 3bdb0da
addressed PR comment
D1v38om83r 855d4a5
Addressed PR comments
D1v38om83r 6e8d333
Update src/Compute/Compute/Generated/Gallery/GalleryCreateOrUpdateMet…
D1v38om83r 2a1d1d2
Update src/Compute/Compute/Generated/Gallery/GalleryCreateOrUpdateMet…
D1v38om83r a338cf2
Update src/Compute/Compute/Generated/Gallery/GalleryCreateOrUpdateMet…
D1v38om83r 1d0372e
Update src/Compute/Compute/ChangeLog.md
D1v38om83r b82952e
Update src/Compute/Compute/Generated/Gallery/GalleryCreateOrUpdateMet…
D1v38om83r 7f85b9c
added null or empty string validation against UserAssignedIdentity pa…
D1v38om83r ed6a697
Re-recorded failed tests
D1v38om83r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.