Skip to content

New package for Az.DesktopVirtualization based on 2025-10-10#29397

Open
Fat-Salty-fish wants to merge 12 commits intoAzure:mainfrom
AVD-RDDAM:users/zhongjieli/Generation-2025-10-10
Open

New package for Az.DesktopVirtualization based on 2025-10-10#29397
Fat-Salty-fish wants to merge 12 commits intoAzure:mainfrom
AVD-RDDAM:users/zhongjieli/Generation-2025-10-10

Conversation

@Fat-Salty-fish
Copy link
Copy Markdown
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings April 13, 2026 08:24
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@VeryEarly
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Az.DesktopVirtualization module/package to align with the 2025-10-10 DesktopVirtualization API version, refreshing generated assets (UX metadata, help/docs, tests/recordings) and adjusting custom cmdlet behavior around host pool registration tokens.

Changes:

  • Bumped DesktopVirtualization UX API versions to 2025-10-10 and refreshed related test recordings.
  • Updated help/reference docs text and parameter surfaces (including new IdentityType documentation for Update-AzWvdHostPool and removal of some -Tag documentation).
  • Simplified New-AzWvdRegistrationInfo / Remove-AzWvdRegistrationInfo custom implementations to call Update-AzWvdHostPool for token operations.

Reviewed changes

Copilot reviewed 72 out of 157 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdWorkspace.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdSessionHost.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdScalingPlanPooledSchedule.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdScalingPlanPersonalSchedule.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdScalingPlan.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdMsixPackage.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdHostPool.md Help updates incl. documented -IdentityType.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdDesktop.md Help updates incl. removed -Tag documentation.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdApplicationGroup.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdApplication.md Help updates incl. removed -Tag documentation.
src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdAppAttachPackage.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdWorkspace.md Help improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdScalingPlanPooledSchedule.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdScalingPlanPersonalSchedule.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdScalingPlan.md Help improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdMsixPackage.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdHostPool.md Help improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdApplicationGroup.md Help improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdApplication.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdAppAttachPackage.md Help text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization/ChangeLog.md Upcoming release notes updated.
src/DesktopVirtualization/DesktopVirtualization/Az.DesktopVirtualization.psd1 Manifest regen timestamp + Az.Accounts requirement update.
src/DesktopVirtualization/DesktopVirtualization.sln Solution project GUID updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/workspaces.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/workspaces-privateEndpointConnections.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/scalingPlans.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/scalingPlans-pooledSchedules.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/scalingPlans-personalSchedules.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-sessionHosts.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-sessionHosts-userSessions.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-privateEndpointConnections.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-msixPackages.json UX API version bump + path casing fix.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/applicationGroups.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/applicationGroups-desktops.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/applicationGroups-applications.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/appAttachPackages.json UX API version bump to 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/utils.ps1 Test env setup refactor/updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdSessionHost.Tests.ps1 Test updated to new persistent SHM vars.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdHostPool.Tests.ps1 Ring assertions updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdApplication.Tests.ps1 Formatting tweaks.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdAppAttachPackage.Tests.ps1 Hostpool selection + MSIX expectations updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Unregister-AzWvdApplicationGroup.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Send-AzWvdUserSessionMessage.Tests.ps1 User session id updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Send-AzWvdUserSessionMessage.Recording.json Recording refreshed for 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdWorkspace.Recording.json Recording refreshed for 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdUserSession.Recording.json Recording refreshed for 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdSessionHost.Tests.ps1 Test updated to SHM vars + Force.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdRegistrationInfo.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdMsixPackage.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdHostPool.Tests.ps1 Ring assertions updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdApplication.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdAppAttachPackage.Tests.ps1 Filtered Get call updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Register-AzWvdApplicationGroup.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdWorkspace.Recording.json Recording refreshed for 2025-10-10.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdScalingPlan.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdRegistrationInfo.Tests.ps1 Indentation fix.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdMsixPackage.Tests.ps1 Added IsActive assertion + removed alias test.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdHostPool.Tests.ps1 Scenario naming change + ring assertions.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdApplicationGroup.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdApplication.Tests.ps1 Persistent app-alias scenario + path updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdAppAttachPackage.Tests.ps1 MSIX expectations now env-driven.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/localEnv.json Local test env values updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Import-AzWvdAppAttachPackageInfo.Tests.ps1 MSIX expectations now env-driven.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdUserSession.Tests.ps1 Uses list results for Get + relaxed counts.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdStartMenuItem.Tests.ps1 Start menu assertions updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdSessionHost.Tests.ps1 Relaxed count assertion.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdScalingPlan.Tests.ps1 Count assertions commented out.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdRegistrationInfo.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdMsixPackage.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdHostPoolRegistrationToken.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdHostPool.Tests.ps1 Ring assertions updated + minor formatting.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdDesktop.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdApplicationGroup.Tests.ps1 Formatting tweaks.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdApplication.Tests.ps1 Formatting tweak.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdAppAttachPackage.Tests.ps1 Added rawIcon/rawPng normalization + sleep.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Expand-AzWvdMsixImage.Tests.ps1 Hostpool source + env-driven expectations.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/env.json Updated committed playback env values.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Disconnect-AzWvdUserSession.Tests.ps1 Dynamically selects a session id to disconnect.
src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Disconnect-AzWvdUserSession.Recording.json Recording refreshed incl. list+disconnect flow.
src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md Spec commit updated + input-file path updated + directive added.
src/DesktopVirtualization/DesktopVirtualization.Autorest/generate-info.json Generation id updated.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdWorkspace.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdSessionHost.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdScalingPlanPooledSchedule.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdScalingPlanPersonalSchedule.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdScalingPlan.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdMsixPackage.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdHostPool.md Doc updates incl. documented -IdentityType.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdDesktop.md Doc updates incl. removed -Tag documentation.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdApplicationGroup.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdApplication.md Doc updates incl. removed -Tag documentation.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdAppAttachPackage.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdWorkspace.md Doc improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdScalingPlanPooledSchedule.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdScalingPlanPersonalSchedule.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdScalingPlan.md Doc improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdMsixPackage.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdHostPool.md Doc improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdApplicationGroup.md Doc improvements for IdentityType/Kind wording.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdApplication.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdAppAttachPackage.md Doc text capitalization updates.
src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Az.DesktopVirtualization.md Module landing doc updates + module GUID change.
src/DesktopVirtualization/DesktopVirtualization.Autorest/custom/Remove-AzWvdRegistrationInfo.ps1 Switches to Update-AzWvdHostPool for delete op.
src/DesktopVirtualization/DesktopVirtualization.Autorest/custom/New-AzWvdRegistrationInfo.ps1 Switches to Update-AzWvdHostPool for update op.

subject-prefix: 'Wvd'
input-file:
- $(repo)/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json
- $(repo)\specification\desktopvirtualization\resource-manager\Microsoft.DesktopVirtualization\DesktopVirtualization\stable\2025-10-10\desktopvirtualization.json
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AutoRest input-file path uses Windows-style backslashes. Other AutoRest READMEs in this repo use forward slashes (e.g., src/Aks/Aks.Autorest/README.md:33-35), and backslashes can break generation on non-Windows environments. Update the input-file entry to use forward slashes and the same path style as other modules.

Suggested change
- $(repo)\specification\desktopvirtualization\resource-manager\Microsoft.DesktopVirtualization\DesktopVirtualization\stable\2025-10-10\desktopvirtualization.json
- $(repo)/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/DesktopVirtualization/stable/2025-10-10/desktopvirtualization.json

Copilot uses AI. Check for mistakes.
Comment on lines 16 to 20
```
Update-AzWvdDesktop -ApplicationGroupName <String> -Name <String> -ResourceGroupName <String>
[-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-Tag <Hashtable>]
[-DefaultProfile <PSObject>] [-WhatIf] [-Confirm] [<CommonParameters>]
[-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-DefaultProfile <PSObject>]
[-WhatIf] [-Confirm] [<CommonParameters>]
```
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update-AzWvdDesktop still has a -Tag parameter (see generated/DesktopVirtualization/DesktopVirtualization.Autorest/exports/Update-AzWvdDesktop.ps1), but this help file no longer documents it in the syntax. Please re-add -Tag to the relevant parameter sets so the published help matches the cmdlet surface area.

Copilot uses AI. Check for mistakes.
Comment on lines 16 to 23
@@ -18,7 +18,7 @@ Update-AzWvdApplication -GroupName <String> -Name <String> -ResourceGroupName <S
[-SubscriptionId <String>] [-ApplicationType <String>] [-CommandLineArgument <String>]
[-CommandLineSetting <String>] [-Description <String>] [-FilePath <String>] [-FriendlyName <String>]
[-IconIndex <Int32>] [-IconPath <String>] [-MsixPackageApplicationId <String>]
[-MsixPackageFamilyName <String>] [-ShowInPortal] [-Tag <Hashtable>] [-DefaultProfile <PSObject>]
[-MsixPackageFamilyName <String>] [-ShowInPortal] [-DefaultProfile <PSObject>]
[-WhatIf] [-Confirm] [<CommonParameters>]
```
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update-AzWvdApplication still supports -Tag (see generated/DesktopVirtualization/DesktopVirtualization.Autorest/exports/Update-AzWvdApplication.ps1), but this help file no longer documents it in the syntax. Please re-add -Tag to the affected parameter sets to keep help in sync with the cmdlet.

Copilot uses AI. Check for mistakes.
Comment on lines 15 to 20
### UpdateExpanded (Default)
```
Update-AzWvdDesktop -ApplicationGroupName <String> -Name <String> -ResourceGroupName <String>
[-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-Tag <Hashtable>]
[-DefaultProfile <PSObject>] [-Confirm] [-WhatIf] [<CommonParameters>]
[-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-DefaultProfile <PSObject>]
[-Confirm] [-WhatIf] [<CommonParameters>]
```
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update-AzWvdDesktop still has a -Tag parameter in the generated cmdlet, but this reference doc no longer includes it in the syntax. Please regenerate or update the doc so -Tag is documented for the applicable parameter sets.

Copilot uses AI. Check for mistakes.
Comment on lines 16 to 23
```
Update-AzWvdApplication -GroupName <String> -Name <String> -ResourceGroupName <String>
[-SubscriptionId <String>] [-ApplicationType <String>] [-CommandLineArgument <String>]
[-CommandLineSetting <String>] [-Description <String>] [-FilePath <String>] [-FriendlyName <String>]
[-IconIndex <Int32>] [-IconPath <String>] [-MsixPackageApplicationId <String>]
[-MsixPackageFamilyName <String>] [-ShowInPortal] [-Tag <Hashtable>] [-DefaultProfile <PSObject>] [-Confirm]
[-WhatIf] [<CommonParameters>]
[-MsixPackageFamilyName <String>] [-ShowInPortal] [-DefaultProfile <PSObject>] [-Confirm] [-WhatIf]
[<CommonParameters>]
```
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update-AzWvdApplication still supports -Tag, but this reference doc no longer includes it in the syntax. Please update/regenerate the doc so it matches the cmdlet parameters.

Copilot uses AI. Check for mistakes.
Comment on lines 18 to 24
[-AgentUpdateMaintenanceWindow <IMaintenanceWindowPatchProperties[]>]
[-AgentUpdateMaintenanceWindowTimeZone <String>] [-AgentUpdateType <String>]
[-AgentUpdateUseSessionHostLocalTime] [-CustomRdpProperty <String>] [-Description <String>]
[-FriendlyName <String>] [-LoadBalancerType <String>] [-MaxSessionLimit <Int32>]
[-FriendlyName <String>] [-IdentityType <String>] [-LoadBalancerType <String>] [-MaxSessionLimit <Int32>]
[-PersonalDesktopAssignmentType <String>] [-PreferredAppGroupType <String>] [-PublicNetworkAccess <String>]
[-RegistrationInfoExpirationTime <DateTime>] [-RegistrationInfoRegistrationTokenOperation <String>]
[-Ring <Int32>] [-SsoadfsAuthority <String>] [-SsoClientId <String>] [-SsoClientSecretKeyVaultPath <String>]
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc now includes -IdentityType in the Update-AzWvdHostPool syntax/parameters, but the generated cmdlet does not expose an IdentityType parameter. Please remove it from the doc (or add it to the cmdlet) so documentation matches the actual API surface.

Copilot uses AI. Check for mistakes.
Comment on lines 136 to 140

Start-Sleep -Seconds 10

$packages = Get-AzWvdAppAttachPackage `
-SubscriptionId $env.SubscriptionId
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test unconditionally sleeps for 10 seconds. In playback mode this adds avoidable latency to CI runs. Prefer a conditional sleep (skip in playback) or reintroduce/use a helper that only sleeps in live/record modes.

Copilot uses AI. Check for mistakes.
Comment on lines 12 to +35
@@ -50,6 +27,12 @@ function setupEnv() {
$null = $env.Add("PvtLinkHP", "PrivateLinkHostPool")
$null = $env.Add("RemoteApplicationGroup", "ApplicationGroupPowershell2")
$null = $env.Add("DesktopApplicationGroup", "ApplicationGroupPowershell1")
# Using vhdx file in the storage account.
$null = $env.Add("MSIXImagePath", "\\liweiavdtestsa.file.core.windows.net\avdtestfs\Apps\VHDX\XmlNotepad\XmlNotepad.vhdx")
$null = $env.Add("MSIXImageFamilyName", "43906ChrisLovett.XmlNotepad_hndwmj480pefj")
$null = $env.Add("MSIXImagePackageName", "43906ChrisLovett.XmlNotepad")
$null = $env.Add("MSIXImagePackageAlias", "43906chrislovettxmlnotepad-1")
$null = $env.Add("MSIXImagePackageRelativePath", "\apps\43906ChrisLovett.XmlNotepad_2.9.0.16_neutral__hndwmj480pefj")
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setupEnv hard-codes environment-specific values (resource group, host pool names, Key Vault name/URIs, and an SMB file share path). This makes the script non-portable for other contributors and CI agents. Consider moving these into env.json/localEnv.json with placeholders, or sourcing them from environment variables/parameters instead of committing tenant-specific defaults.

Copilot uses AI. Check for mistakes.
Comment on lines +21 to +22
* Added MultiplePersistent enum value to HostPool property loadBalancerType.
* Fixed issue when `New-AzWvdRegistrationInfo` cmdlet execution failed if public network access was disabled on the host pool.
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry has awkward phrasing: "Fixed issue when ... failed when ...". Consider rewording to "Fixed an issue where New-AzWvdRegistrationInfo failed when public network access was disabled on the host pool."

Copilot uses AI. Check for mistakes.
Comment on lines 22 to +30
-LoadBalancerType 'DepthFirst' `
-PreferredAppGroupType 'Desktop' `
-DesktopAppGroupName 'FullScenarioCreateAG' `
-WorkspaceName 'FullScenarioCreateWS'
-DesktopAppGroupName 'FullSenerioCreateAG' `
-WorkspaceName 'FullSenerioCreateWS'
}
finally{
$applicationGroup = Remove-AzWvdApplicationGroup -SubscriptionId $env.SubscriptionId `
-ResourceGroupName $env.ResourceGroup `
-Name 'FullScenarioCreateAG'
-Name 'FullSenerioCreateAG'
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in scenario name: "FullSenerio" should be "FullScenario" for readability/maintainability (even if it’s only a test resource name).

Copilot uses AI. Check for mistakes.
@VeryEarly VeryEarly self-assigned this Apr 14, 2026
@VeryEarly
Copy link
Copy Markdown
Collaborator

Hi @Fat-Salty-fish ,
Please be aware there are breaking changes in this PR, are they intended? If yes, please create a separate PR to announce breaking changes ASAP and wait for next month for breaking changes.

@VeryEarly
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly removed their assignment Apr 15, 2026
@VeryEarly VeryEarly added the Contains Breaking Change This PR contains breaking change label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants