New package for Az.DesktopVirtualization based on 2025-10-10#29397
New package for Az.DesktopVirtualization based on 2025-10-10#29397Fat-Salty-fish wants to merge 12 commits intoAzure:mainfrom
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Updates the Az.DesktopVirtualization module/package to align with the 2025-10-10 DesktopVirtualization API version, refreshing generated assets (UX metadata, help/docs, tests/recordings) and adjusting custom cmdlet behavior around host pool registration tokens.
Changes:
- Bumped DesktopVirtualization UX API versions to
2025-10-10and refreshed related test recordings. - Updated help/reference docs text and parameter surfaces (including new
IdentityTypedocumentation forUpdate-AzWvdHostPooland removal of some-Tagdocumentation). - Simplified
New-AzWvdRegistrationInfo/Remove-AzWvdRegistrationInfocustom implementations to callUpdate-AzWvdHostPoolfor token operations.
Reviewed changes
Copilot reviewed 72 out of 157 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdWorkspace.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdSessionHost.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdScalingPlanPooledSchedule.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdScalingPlanPersonalSchedule.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdScalingPlan.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdMsixPackage.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdHostPool.md | Help updates incl. documented -IdentityType. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdDesktop.md | Help updates incl. removed -Tag documentation. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdApplicationGroup.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdApplication.md | Help updates incl. removed -Tag documentation. |
| src/DesktopVirtualization/DesktopVirtualization/help/Update-AzWvdAppAttachPackage.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdWorkspace.md | Help improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdScalingPlanPooledSchedule.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdScalingPlanPersonalSchedule.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdScalingPlan.md | Help improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdMsixPackage.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdHostPool.md | Help improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdApplicationGroup.md | Help improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdApplication.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/help/New-AzWvdAppAttachPackage.md | Help text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization/ChangeLog.md | Upcoming release notes updated. |
| src/DesktopVirtualization/DesktopVirtualization/Az.DesktopVirtualization.psd1 | Manifest regen timestamp + Az.Accounts requirement update. |
| src/DesktopVirtualization/DesktopVirtualization.sln | Solution project GUID updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/workspaces.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/workspaces-privateEndpointConnections.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/scalingPlans.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/scalingPlans-pooledSchedules.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/scalingPlans-personalSchedules.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-sessionHosts.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-sessionHosts-userSessions.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-privateEndpointConnections.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/hostPools-msixPackages.json | UX API version bump + path casing fix. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/applicationGroups.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/applicationGroups-desktops.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/applicationGroups-applications.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/UX/Microsoft.DesktopVirtualization/appAttachPackages.json | UX API version bump to 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/utils.ps1 | Test env setup refactor/updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdSessionHost.Tests.ps1 | Test updated to new persistent SHM vars. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdHostPool.Tests.ps1 | Ring assertions updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdApplication.Tests.ps1 | Formatting tweaks. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Update-AzWvdAppAttachPackage.Tests.ps1 | Hostpool selection + MSIX expectations updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Unregister-AzWvdApplicationGroup.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Send-AzWvdUserSessionMessage.Tests.ps1 | User session id updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Send-AzWvdUserSessionMessage.Recording.json | Recording refreshed for 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdWorkspace.Recording.json | Recording refreshed for 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdUserSession.Recording.json | Recording refreshed for 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdSessionHost.Tests.ps1 | Test updated to SHM vars + Force. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdRegistrationInfo.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdMsixPackage.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdHostPool.Tests.ps1 | Ring assertions updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdApplication.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Remove-AzWvdAppAttachPackage.Tests.ps1 | Filtered Get call updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Register-AzWvdApplicationGroup.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdWorkspace.Recording.json | Recording refreshed for 2025-10-10. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdScalingPlan.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdRegistrationInfo.Tests.ps1 | Indentation fix. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdMsixPackage.Tests.ps1 | Added IsActive assertion + removed alias test. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdHostPool.Tests.ps1 | Scenario naming change + ring assertions. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdApplicationGroup.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdApplication.Tests.ps1 | Persistent app-alias scenario + path updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdAppAttachPackage.Tests.ps1 | MSIX expectations now env-driven. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/localEnv.json | Local test env values updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Import-AzWvdAppAttachPackageInfo.Tests.ps1 | MSIX expectations now env-driven. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdUserSession.Tests.ps1 | Uses list results for Get + relaxed counts. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdStartMenuItem.Tests.ps1 | Start menu assertions updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdSessionHost.Tests.ps1 | Relaxed count assertion. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdScalingPlan.Tests.ps1 | Count assertions commented out. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdRegistrationInfo.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdMsixPackage.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdHostPoolRegistrationToken.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdHostPool.Tests.ps1 | Ring assertions updated + minor formatting. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdDesktop.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdApplicationGroup.Tests.ps1 | Formatting tweaks. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdApplication.Tests.ps1 | Formatting tweak. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Get-AzWvdAppAttachPackage.Tests.ps1 | Added rawIcon/rawPng normalization + sleep. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Expand-AzWvdMsixImage.Tests.ps1 | Hostpool source + env-driven expectations. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/env.json | Updated committed playback env values. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Disconnect-AzWvdUserSession.Tests.ps1 | Dynamically selects a session id to disconnect. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/test/Disconnect-AzWvdUserSession.Recording.json | Recording refreshed incl. list+disconnect flow. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md | Spec commit updated + input-file path updated + directive added. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/generate-info.json | Generation id updated. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdWorkspace.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdSessionHost.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdScalingPlanPooledSchedule.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdScalingPlanPersonalSchedule.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdScalingPlan.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdMsixPackage.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdHostPool.md | Doc updates incl. documented -IdentityType. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdDesktop.md | Doc updates incl. removed -Tag documentation. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdApplicationGroup.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdApplication.md | Doc updates incl. removed -Tag documentation. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Update-AzWvdAppAttachPackage.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdWorkspace.md | Doc improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdScalingPlanPooledSchedule.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdScalingPlanPersonalSchedule.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdScalingPlan.md | Doc improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdMsixPackage.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdHostPool.md | Doc improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdApplicationGroup.md | Doc improvements for IdentityType/Kind wording. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdApplication.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/New-AzWvdAppAttachPackage.md | Doc text capitalization updates. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/docs/Az.DesktopVirtualization.md | Module landing doc updates + module GUID change. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/custom/Remove-AzWvdRegistrationInfo.ps1 | Switches to Update-AzWvdHostPool for delete op. |
| src/DesktopVirtualization/DesktopVirtualization.Autorest/custom/New-AzWvdRegistrationInfo.ps1 | Switches to Update-AzWvdHostPool for update op. |
| subject-prefix: 'Wvd' | ||
| input-file: | ||
| - $(repo)/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json | ||
| - $(repo)\specification\desktopvirtualization\resource-manager\Microsoft.DesktopVirtualization\DesktopVirtualization\stable\2025-10-10\desktopvirtualization.json |
There was a problem hiding this comment.
The AutoRest input-file path uses Windows-style backslashes. Other AutoRest READMEs in this repo use forward slashes (e.g., src/Aks/Aks.Autorest/README.md:33-35), and backslashes can break generation on non-Windows environments. Update the input-file entry to use forward slashes and the same path style as other modules.
| - $(repo)\specification\desktopvirtualization\resource-manager\Microsoft.DesktopVirtualization\DesktopVirtualization\stable\2025-10-10\desktopvirtualization.json | |
| - $(repo)/specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/DesktopVirtualization/stable/2025-10-10/desktopvirtualization.json |
| ``` | ||
| Update-AzWvdDesktop -ApplicationGroupName <String> -Name <String> -ResourceGroupName <String> | ||
| [-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-Tag <Hashtable>] | ||
| [-DefaultProfile <PSObject>] [-WhatIf] [-Confirm] [<CommonParameters>] | ||
| [-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-DefaultProfile <PSObject>] | ||
| [-WhatIf] [-Confirm] [<CommonParameters>] | ||
| ``` |
There was a problem hiding this comment.
Update-AzWvdDesktop still has a -Tag parameter (see generated/DesktopVirtualization/DesktopVirtualization.Autorest/exports/Update-AzWvdDesktop.ps1), but this help file no longer documents it in the syntax. Please re-add -Tag to the relevant parameter sets so the published help matches the cmdlet surface area.
| @@ -18,7 +18,7 @@ Update-AzWvdApplication -GroupName <String> -Name <String> -ResourceGroupName <S | |||
| [-SubscriptionId <String>] [-ApplicationType <String>] [-CommandLineArgument <String>] | |||
| [-CommandLineSetting <String>] [-Description <String>] [-FilePath <String>] [-FriendlyName <String>] | |||
| [-IconIndex <Int32>] [-IconPath <String>] [-MsixPackageApplicationId <String>] | |||
| [-MsixPackageFamilyName <String>] [-ShowInPortal] [-Tag <Hashtable>] [-DefaultProfile <PSObject>] | |||
| [-MsixPackageFamilyName <String>] [-ShowInPortal] [-DefaultProfile <PSObject>] | |||
| [-WhatIf] [-Confirm] [<CommonParameters>] | |||
| ``` | |||
There was a problem hiding this comment.
Update-AzWvdApplication still supports -Tag (see generated/DesktopVirtualization/DesktopVirtualization.Autorest/exports/Update-AzWvdApplication.ps1), but this help file no longer documents it in the syntax. Please re-add -Tag to the affected parameter sets to keep help in sync with the cmdlet.
| ### UpdateExpanded (Default) | ||
| ``` | ||
| Update-AzWvdDesktop -ApplicationGroupName <String> -Name <String> -ResourceGroupName <String> | ||
| [-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-Tag <Hashtable>] | ||
| [-DefaultProfile <PSObject>] [-Confirm] [-WhatIf] [<CommonParameters>] | ||
| [-SubscriptionId <String>] [-Description <String>] [-FriendlyName <String>] [-DefaultProfile <PSObject>] | ||
| [-Confirm] [-WhatIf] [<CommonParameters>] | ||
| ``` |
There was a problem hiding this comment.
Update-AzWvdDesktop still has a -Tag parameter in the generated cmdlet, but this reference doc no longer includes it in the syntax. Please regenerate or update the doc so -Tag is documented for the applicable parameter sets.
| ``` | ||
| Update-AzWvdApplication -GroupName <String> -Name <String> -ResourceGroupName <String> | ||
| [-SubscriptionId <String>] [-ApplicationType <String>] [-CommandLineArgument <String>] | ||
| [-CommandLineSetting <String>] [-Description <String>] [-FilePath <String>] [-FriendlyName <String>] | ||
| [-IconIndex <Int32>] [-IconPath <String>] [-MsixPackageApplicationId <String>] | ||
| [-MsixPackageFamilyName <String>] [-ShowInPortal] [-Tag <Hashtable>] [-DefaultProfile <PSObject>] [-Confirm] | ||
| [-WhatIf] [<CommonParameters>] | ||
| [-MsixPackageFamilyName <String>] [-ShowInPortal] [-DefaultProfile <PSObject>] [-Confirm] [-WhatIf] | ||
| [<CommonParameters>] | ||
| ``` |
There was a problem hiding this comment.
Update-AzWvdApplication still supports -Tag, but this reference doc no longer includes it in the syntax. Please update/regenerate the doc so it matches the cmdlet parameters.
| [-AgentUpdateMaintenanceWindow <IMaintenanceWindowPatchProperties[]>] | ||
| [-AgentUpdateMaintenanceWindowTimeZone <String>] [-AgentUpdateType <String>] | ||
| [-AgentUpdateUseSessionHostLocalTime] [-CustomRdpProperty <String>] [-Description <String>] | ||
| [-FriendlyName <String>] [-LoadBalancerType <String>] [-MaxSessionLimit <Int32>] | ||
| [-FriendlyName <String>] [-IdentityType <String>] [-LoadBalancerType <String>] [-MaxSessionLimit <Int32>] | ||
| [-PersonalDesktopAssignmentType <String>] [-PreferredAppGroupType <String>] [-PublicNetworkAccess <String>] | ||
| [-RegistrationInfoExpirationTime <DateTime>] [-RegistrationInfoRegistrationTokenOperation <String>] | ||
| [-Ring <Int32>] [-SsoadfsAuthority <String>] [-SsoClientId <String>] [-SsoClientSecretKeyVaultPath <String>] |
There was a problem hiding this comment.
The doc now includes -IdentityType in the Update-AzWvdHostPool syntax/parameters, but the generated cmdlet does not expose an IdentityType parameter. Please remove it from the doc (or add it to the cmdlet) so documentation matches the actual API surface.
|
|
||
| Start-Sleep -Seconds 10 | ||
|
|
||
| $packages = Get-AzWvdAppAttachPackage ` | ||
| -SubscriptionId $env.SubscriptionId |
There was a problem hiding this comment.
This test unconditionally sleeps for 10 seconds. In playback mode this adds avoidable latency to CI runs. Prefer a conditional sleep (skip in playback) or reintroduce/use a helper that only sleeps in live/record modes.
| @@ -50,6 +27,12 @@ function setupEnv() { | |||
| $null = $env.Add("PvtLinkHP", "PrivateLinkHostPool") | |||
| $null = $env.Add("RemoteApplicationGroup", "ApplicationGroupPowershell2") | |||
| $null = $env.Add("DesktopApplicationGroup", "ApplicationGroupPowershell1") | |||
| # Using vhdx file in the storage account. | |||
| $null = $env.Add("MSIXImagePath", "\\liweiavdtestsa.file.core.windows.net\avdtestfs\Apps\VHDX\XmlNotepad\XmlNotepad.vhdx") | |||
| $null = $env.Add("MSIXImageFamilyName", "43906ChrisLovett.XmlNotepad_hndwmj480pefj") | |||
| $null = $env.Add("MSIXImagePackageName", "43906ChrisLovett.XmlNotepad") | |||
| $null = $env.Add("MSIXImagePackageAlias", "43906chrislovettxmlnotepad-1") | |||
| $null = $env.Add("MSIXImagePackageRelativePath", "\apps\43906ChrisLovett.XmlNotepad_2.9.0.16_neutral__hndwmj480pefj") | |||
There was a problem hiding this comment.
setupEnv hard-codes environment-specific values (resource group, host pool names, Key Vault name/URIs, and an SMB file share path). This makes the script non-portable for other contributors and CI agents. Consider moving these into env.json/localEnv.json with placeholders, or sourcing them from environment variables/parameters instead of committing tenant-specific defaults.
| * Added MultiplePersistent enum value to HostPool property loadBalancerType. | ||
| * Fixed issue when `New-AzWvdRegistrationInfo` cmdlet execution failed if public network access was disabled on the host pool. |
There was a problem hiding this comment.
Changelog entry has awkward phrasing: "Fixed issue when ... failed when ...". Consider rewording to "Fixed an issue where New-AzWvdRegistrationInfo failed when public network access was disabled on the host pool."
| -LoadBalancerType 'DepthFirst' ` | ||
| -PreferredAppGroupType 'Desktop' ` | ||
| -DesktopAppGroupName 'FullScenarioCreateAG' ` | ||
| -WorkspaceName 'FullScenarioCreateWS' | ||
| -DesktopAppGroupName 'FullSenerioCreateAG' ` | ||
| -WorkspaceName 'FullSenerioCreateWS' | ||
| } | ||
| finally{ | ||
| $applicationGroup = Remove-AzWvdApplicationGroup -SubscriptionId $env.SubscriptionId ` | ||
| -ResourceGroupName $env.ResourceGroup ` | ||
| -Name 'FullScenarioCreateAG' | ||
| -Name 'FullSenerioCreateAG' |
There was a problem hiding this comment.
Typo in scenario name: "FullSenerio" should be "FullScenario" for readability/maintainability (even if it’s only a test resource name).
|
Hi @Fat-Salty-fish , |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
To the author of the pull request, |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.