-
Notifications
You must be signed in to change notification settings - Fork 13
Remove hardcoded v143 toolset from vcpkg triplets and new VLD ignore #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
anporumb
wants to merge
11
commits into
master
Choose a base branch
from
anporumb/remove_v143_dependency
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0d32713
Remove hardcoded v143 toolset from vcpkg triplets
anporumb c926a15
Add Winsock VLD suppressions for false-positive leak reports
anporumb 56d6182
Revert "Add Winsock VLD suppressions for false-positive leak reports"
anporumb 7f17bc6
Add Winsock/DNS VLD suppressions for false-positive leak reports
anporumb 0c712c6
Add WahCreateHandleContextTable to VLD suppressions
anporumb a1ec5e8
Include GBALLOC_LL_TYPE in artifact name to avoid collision
anporumb 9072530
Add getaddrinfo to VLD IgnoreFunctionsList
anporumb 5aa4add
Use WSALookupServiceBeginW instead of getaddrinfo for VLD suppression
anporumb 3358856
Add IgnoreModulesList for system DLL false positives in VLD config
anporumb 2fa56dc
Fix default_vld.ini comment: accurate system DLL leak documentation
anporumb b435bbd
trying only IgnoreModulesList = rasadhlp.dll not more
anporumb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really have to double check this comment. This caused us to have a hotfix when it happened - I remember that coverage with offload showed some issues but it did get to production, so we should not take it lightly and at least we should ensure that the thing we build with in the gate has the code we want ...
Sorry, it sounds panicky, but at 5k clusters I really don't want to run around patching and retaking stuff if we knew of a potential issue.