Monitoring dashboard support#385
Merged
Merged
Conversation
azreenz
reviewed
Jun 18, 2026
abatallas
force-pushed
the
abatallas/slurm_dashboard_support
branch
from
June 19, 2026 16:49
656506b to
38a2208
Compare
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for integrating Azure Monitor workspace + Azure Managed Grafana into the deployment flow, including surfacing selectors in the Create UI Definition, plumbing the resulting IDs into the Bicep types/params, assigning RBAC roles, and installing Slurm dashboards into the selected Grafana instance from the deployed VM.
Changes:
- Replace manual monitoring endpoint/DCR inputs with resource selectors for Azure Monitor workspace and Azure Managed Grafana, and derive ingestion/DCR values via ARM API.
- Extend monitoring parameter types to include Monitor workspace ID and Grafana ID, and expose Grafana metadata via deployment outputs.
- Add role assignment support for Grafana Admin + monitoring publishing, and run a post-deploy script step to add Slurm dashboards to Grafana.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| uidefinitions/createUiDefinition.json | Adds Azure Monitor workspace + Grafana selectors and derives ingestion endpoint/DCR from the selected workspace. |
| bicep/vmMonitoringRoleAssignments.bicep | New module to assign RBAC roles at resource-group scope for the CycleCloud VM principal. |
| bicep/types.bicep | Extends monitoring_enabled_t to include monitorWorkspaceId and grafanaId. |
| bicep/install.sh | Downloads the monitoring project release tarball and invokes dashboard installation for the selected Grafana instance. |
| bicep/exports.bicep | Adds a role definition lookup entry for Grafana Admin. |
| bicep/ccw.bicep | Wires in monitoring RBAC module + adds Grafana details to outputs for consumption by install script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bwatrous
reviewed
Jun 19, 2026
bwatrous
reviewed
Jun 19, 2026
bwatrous
reviewed
Jun 19, 2026
bwatrous
reviewed
Jun 19, 2026
abatallas
force-pushed
the
abatallas/slurm_dashboard_support
branch
2 times, most recently
from
June 22, 2026 17:03
3054328 to
5fa11c5
Compare
Align types.bicep with UI definition outputs Add Grafana Admin role assignment to CC VM MI Add Grafana workspace name to monitoring output in ccw.bicep Output Grafana resource ID in UI definition Re-add DCR resource ID to UI def outputs Add slurm dashboards in cloud-init Dynamically get monitoring project version associated with Slurm project on CC image Use add_dashboards.sh rather than add_slurm_dashboards.sh from monitoring project Add monitor workspace ID to UI def outputs Always have user select AMG instance Assign monitoring roles to CC VM with narrow scoping Fix monitoring ingestion endpoint URI
abatallas
force-pushed
the
abatallas/slurm_dashboard_support
branch
from
June 22, 2026 18:17
5fa11c5 to
e0af984
Compare
ryanhamel
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.