Simplify public key logic#386
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR streamlines SSH public key input by consolidating “entered vs stored” selection into a single key object passed from the Portal UI definition into the Bicep templates, removing placeholder (“foo”) values previously surfaced to users in deployment parameters.
Changes:
- Replaces
autogeneratePasswordsAndKeyswithpublicKeySourcein the Portal UI and outputs a unifiedkey { type, value, id }object. - Introduces a discriminated-union
publicKey_tin Bicep and updates templates/modules to consume it. - Simplifies the public key module interface to take only the stored key resource ID.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| uidefinitions/createUiDefinition.json | Renames and rewires UI inputs; emits consolidated key output object. |
| bicep/types.bicep | Adds publicKey_t discriminated union for entered/stored key variants. |
| bicep/publicKey.bicep | Updates module contract to accept a stored key resource ID and output the public key. |
| bicep/mainTemplate.bicep | Replaces separate SSH key params with unified key parameter passed to ccw.bicep. |
| bicep/ccw.bicep | Resolves the effective SSH public key from either stored key lookup or entered value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryanhamel
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally part of #123, this PR streamlines how we handle input of SSH public keys. Most notably, it removes the various instances of "foo" exposed to the user when they try to view deployment parameters in the Portal.