Skip to content

Simplify public key logic#386

Merged
abatallas merged 4 commits into
mainfrom
abatallas/simplify_public_key
Jun 24, 2026
Merged

Simplify public key logic#386
abatallas merged 4 commits into
mainfrom
abatallas/simplify_public_key

Conversation

@abatallas

Copy link
Copy Markdown
Contributor

Originally part of #123, this PR streamlines how we handle input of SSH public keys. Most notably, it removes the various instances of "foo" exposed to the user when they try to view deployment parameters in the Portal.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines SSH public key input by consolidating “entered vs stored” selection into a single key object passed from the Portal UI definition into the Bicep templates, removing placeholder (“foo”) values previously surfaced to users in deployment parameters.

Changes:

  • Replaces autogeneratePasswordsAndKeys with publicKeySource in the Portal UI and outputs a unified key { type, value, id } object.
  • Introduces a discriminated-union publicKey_t in Bicep and updates templates/modules to consume it.
  • Simplifies the public key module interface to take only the stored key resource ID.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
uidefinitions/createUiDefinition.json Renames and rewires UI inputs; emits consolidated key output object.
bicep/types.bicep Adds publicKey_t discriminated union for entered/stored key variants.
bicep/publicKey.bicep Updates module contract to accept a stored key resource ID and output the public key.
bicep/mainTemplate.bicep Replaces separate SSH key params with unified key parameter passed to ccw.bicep.
bicep/ccw.bicep Resolves the effective SSH public key from either stored key lookup or entered value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread uidefinitions/createUiDefinition.json Outdated
Comment thread bicep/ccw.bicep
Comment thread bicep/ccw.bicep Outdated
@abatallas
abatallas merged commit e301e3b into main Jun 24, 2026
2 checks passed
@abatallas
abatallas deleted the abatallas/simplify_public_key branch June 24, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants