Skip to content

Simplification of peered vnet logic#388

Merged
abatallas merged 2 commits into
mainfrom
abatallas/simplify_peered_vnet_logic
Jun 24, 2026
Merged

Simplification of peered vnet logic#388
abatallas merged 2 commits into
mainfrom
abatallas/simplify_peered_vnet_logic

Conversation

@abatallas

@abatallas abatallas commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Originally part of #123, removes unused fields in UI definition outputs

Comment thread bicep/types.bicep

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies VNet peering-related outputs from the Marketplace UI definition and aligns the Bicep types/consumption with the streamlined output shape to support easier downstream (non-UI) Bicep deployments.

Changes:

  • Collapses peering outputs into a single network.vnetToPeer object that includes the peered VNet id plus a gateway-transit flag.
  • Updates the peered_vnet_t type to remove unused fields and include the gateway-transit flag.
  • Updates network-new.bicep to read useRemoteGateways from network.vnetToPeer.allowGatewayTransit.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
uidefinitions/createUiDefinition.json Consolidates peering-related outputs into vnetToPeer with id + allowGatewayTransit.
bicep/types.bicep Adjusts the peered VNet type to match the simplified output contract.
bicep/network-new.bicep Switches peering configuration to consume allowGatewayTransit from vnetToPeer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread uidefinitions/createUiDefinition.json
Comment thread bicep/types.bicep
@abatallas
abatallas merged commit 9edea16 into main Jun 24, 2026
2 checks passed
@abatallas
abatallas deleted the abatallas/simplify_peered_vnet_logic branch June 24, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants