Remove job related metrics/dashboards #534
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes per-job (high-cardinality) Prometheus metrics and the Grafana dashboards/panels that depended on them, to reduce Prometheus/Azure Monitor backend series growth and associated operational risk.
Changes:
- Removed the per-job
squeue_job_nodes_allocatedmetric from thesqueuecollector and updated unit tests accordingly. - Removed the per-job
sacct_failed_jobsmetric from thesacctcollector and updated unit tests accordingly. - Deleted the “Failed Jobs” dashboard and removed job/failed-job panels from the “Extra Details” dashboard; updated dashboard navigation text and README exported-metrics documentation.
| Criterion | Max Points | Points Awarded | Notes |
|---|---|---|---|
| PR Description Accuracy | 20 | 20 | Matches changes (removal of high-cardinality metrics/dashboards). |
| PR Atomicity | 20 | 20 | Single cohesive change: remove job-level metrics and dependent dashboards/tests/docs. |
| Logical Implementation | 10 | 10 | Straightforward removals; remaining collectors align with updated behavior. |
| Regression Risk | 10 | 10 | Change is intentionally breaking for removed metrics/dashboards and is described. |
| Exception Handling | 10 | 10 | No degradation vs existing error handling patterns. |
| Code Comments | 10 | 10 | Docstrings updated to reflect the new single-metric outputs. |
| Repetitive Code | 10 | 10 | No new duplication introduced. |
| Spelling | 5 | 5 | No spelling issues found in modified text. |
| Logging Quality | 5 | 5 | No negative changes to logging clarity/levels. |
FINAL SCORE: 100/100
RECOMMENDATION: MERGE
RATIONALE: The PR cleanly removes the targeted high-cardinality metrics and updates tests/docs/dashboards consistently.
BLOCKERS: None
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes documentation for the deleted job-level metrics. |
| azure-slurm-exporter/exporter/squeue.py | Removes per-job node allocation metric; keeps partition/state job counts. |
| azure-slurm-exporter/exporter/sacct.py | Removes per-job failed-jobs gauge; keeps terminal-jobs counter. |
| azure-slurm-exporter/test/test_squeue.py | Updates expectations to the single remaining squeue metric. |
| azure-slurm-exporter/test/test_sacct.py | Updates expectations to the single remaining sacct metric. |
| azure-slurm-exporter/dashboards/library-panels/azslurm-dashboard-buttons.json | Updates button label text for the details dashboard. |
| azure-slurm-exporter/dashboards/failed-jobs.json | Deletes the failed-jobs dashboard. |
| azure-slurm-exporter/dashboards/azslurm-details.json | Removes job/failed-job panels and updates dashboard description/layout. |
Collaborator
Author
bwatrous
previously approved these changes
Jun 26, 2026
aditigaur4
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Remove metrics with high cardinality labels to reduce prometheus backend explosion