Disable sacct metrics if sacct exists but accounting is disabled

[azreenz]

Check AccountStorageType in scontrol show config during intialize step to check for slurm accounting. If accounting is disabled we disable the collector in the exporter. If scontrol show config fails to run during intialize step ie we don't know accounting is explictly disabled we allow the collector to run.

When sacct exisits but accounting is disabled we get the following warning in the log:

2026-06-30 15:09:13 INFO: Starting Azure SLURM Prometheus Exporter v0.2.0
2026-06-30 15:09:13 WARNING: Slurm accounting storage is disabled
2026-06-30 15:09:13 WARNING: Accounting is disabled, disabling sacct metrics
2026-06-30 15:09:13 INFO: Prometheus exporter serving on http://0.0.0.0:9101/metrics
2026-06-30 15:09:13 DEBUG: Command: /usr/bin/squeue -h -o %i|%j|%D|%N|%P|%T|%V|%S|%u, Exit code: 0, Time Elapsed: 0.016286
2026-06-30 15:09:13 DEBUG: Command: /usr/bin/sinfo -h -o %N|%D|%R|%E|%T, Exit code: 0, Time Elapsed: 0.015528
2026-06-30 15:09:13 DEBUG: Command: /usr/bin/sdiag --json, Exit code: 0, Time Elapsed: 0.014899
2026-06-30 15:09:14 DEBUG: Command: /opt/cycle/jetpack/bin/jetpack config azure.metadata.compute.location None, Exit code: 0, Time Elapsed: 0.341106

[Copilot]

Pull request overview

This PR updates the Slurm sacct collector initialization to synchronously “preflight” sacct so the exporter can disable sacct metrics when Slurm accounting storage is disabled, and adjusts unit tests to mock the new subprocess call.

Changes:

• Add an sacct preflight call during Sacct.initialize() to detect the “Slurm accounting storage is disabled” message and raise SacctNotAvailException.
• Add/adjust tests to mock subprocess.run and validate the accounting-disabled behavior.

Criterion	Max Points	Points Awarded	Notes
PR Description Accuracy	20	20	Matches the changes (preflight to detect accounting disabled and disable collector).
PR Atomicity	20	20	Single cohesive change (collector behavior + tests).
Logical Implementation	10	10	Straightforward and localized.
Regression Risk	10	0	Disabling the collector on init can change global Prometheus output (see comment about disable_created_metrics() ordering).
Exception Handling	10	10	Preflight failure is handled without breaking init flow.
Code Comments	10	10	No problematic commentary introduced.
Repetitive Code	10	10	No significant duplication introduced.
Spelling	5	5	No spelling issues found in the changed code.
Logging Quality	5	5	Logging is generally clear for preflight failures/disablement.

FINAL SCORE: 90/100

RECOMMENDATION: MERGE
RATIONALE: The change aligns with the PR’s goal and test coverage was updated accordingly. Consider addressing the noted Prometheus global-metric side effect to avoid unexpected output changes when accounting is disabled.
BLOCKERS: None

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
azure-slurm-exporter/exporter/sacct.py	Adds sacct preflight during initialization to detect disabled accounting and disable the collector.
azure-slurm-exporter/test/test_sacct.py	Mocks the new subprocess preflight call and adds a test for the accounting-disabled case.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.