-
Notifications
You must be signed in to change notification settings - Fork 332
Add support for parsing DateTime values #3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArjunNarendra
wants to merge
6
commits into
Azure:main
Choose a base branch
from
ArjunNarendra:user/an/postgres-db-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−1
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2fd8ee4
Add support for parsing DateTime values
ArjunNarendra 1358975
Update parsing to reflect that only support (for now) is for DATETIME…
ArjunNarendra 18d4f90
Unit tests to verify correctness
ArjunNarendra ecd6403
Remove unnecessary call to DateTimeStyles.AdjustToUniversal because w…
ArjunNarendra 648b7b4
Add a TODO comment to look into support for SupportedHotChocolateType…
ArjunNarendra 030ed45
Add integration tests to test end-to-end flow
ArjunNarendra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System; | ||
| using Azure.DataApiBuilder.Service.Services; | ||
| using HotChocolate.Execution; | ||
| using HotChocolate.Language; | ||
| using HotChocolate.Types; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
| using Moq; | ||
|
|
||
| namespace Azure.DataApiBuilder.Service.Tests.UnitTests; | ||
|
|
||
| [TestClass] | ||
| public class ExecutionHelperUnitTests | ||
| { | ||
| [TestMethod] | ||
| public void ExtractValueFromIValueNode_DateTimeLiteral_ReturnsUtcDateTime() | ||
| { | ||
| Mock<IInputValueDefinition> argumentSchema = CreateArgumentSchema(new DateTimeType()); | ||
| Mock<IVariableValueCollection> variables = new(); | ||
|
|
||
| object result = ExecutionHelper.ExtractValueFromIValueNode( | ||
| new StringValueNode("2026-04-22T10:15:30-07:00"), | ||
| argumentSchema.Object, | ||
| variables.Object); | ||
|
|
||
| Assert.IsInstanceOfType<DateTime>(result); | ||
| Assert.AreEqual( | ||
| new DateTime(2026, 4, 22, 17, 15, 30, DateTimeKind.Utc), | ||
| (DateTime)result); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void ExtractValueFromIValueNode_DateTimeVariable_ReturnsUtcDateTime() | ||
| { | ||
| Mock<IInputValueDefinition> argumentSchema = CreateArgumentSchema(new DateTimeType()); | ||
| Mock<IVariableValueCollection> variables = new(); | ||
| variables | ||
| .Setup(v => v.GetValue<IValueNode>("createdAt")) | ||
| .Returns(new StringValueNode("2026-04-22T10:15:30Z")); | ||
|
|
||
| object result = ExecutionHelper.ExtractValueFromIValueNode( | ||
| new VariableNode("createdAt"), | ||
| argumentSchema.Object, | ||
| variables.Object); | ||
|
|
||
| Assert.IsInstanceOfType<DateTime>(result); | ||
| Assert.AreEqual( | ||
| new DateTime(2026, 4, 22, 10, 15, 30, DateTimeKind.Utc), | ||
| (DateTime)result); | ||
| } | ||
|
|
||
| private static Mock<IInputValueDefinition> CreateArgumentSchema(IInputType type) | ||
| { | ||
| Mock<IInputValueDefinition> argumentSchema = new(); | ||
| argumentSchema.SetupGet(a => a.Type).Returns(type); | ||
| return argumentSchema; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not make too much sense to me...if we are dealing with
SupportedHotChocolateTypes.DATETIME_TYPEshouldn't we return aDateTime(not aDateTimeOffset)?