Skip to content

Missing/Invalid Default Value (Group 4)#3454

Open
souvikghosh04 wants to merge 3 commits intomainfrom
Usr/sogh/grp4-invalid-defaults
Open

Missing/Invalid Default Value (Group 4)#3454
souvikghosh04 wants to merge 3 commits intomainfrom
Usr/sogh/grp4-invalid-defaults

Conversation

@souvikghosh04
Copy link
Copy Markdown
Contributor

@souvikghosh04 souvikghosh04 commented Apr 16, 2026

Why make this change?

Parent issue #3466
Closes #3366runtime.rest.enabled has no default in the JSON schema
Closes #3367runtime.graphql.enabled has no default in the JSON schema

These schema properties were missing an explicit default value.

5 of 7 Group 4 issues (#3378#3382) were already fixed in PR #3417 as Group 2 overlaps.

What is this change?

Adds "default": true to the enabled property under both runtime.rest and runtime.graphql in schemas/dab.draft.schema.json. This matches the C# runtime behavior where both REST and GraphQL are enabled by default.

How was this tested?

Schema-only metadata change — no runtime behavior affected. Validated that the schema still passes JSON Schema draft-07 validation.

Sample Request(s)

NA

@souvikghosh04 souvikghosh04 self-assigned this Apr 24, 2026
@souvikghosh04 souvikghosh04 added this to the April 2026 milestone Apr 24, 2026
@souvikghosh04 souvikghosh04 marked this pull request as ready for review April 24, 2026 08:09
Copilot AI review requested due to automatic review settings April 24, 2026 08:09
@souvikghosh04 souvikghosh04 moved this from Todo to Review In Progress in Data API builder Apr 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the DAB JSON schema to explicitly document the runtime defaults for enabling REST and GraphQL endpoints, aligning schema annotations with the existing runtime behavior implemented in the C# options records.

Changes:

  • Add "default": true for runtime.rest.enabled in dab.draft.schema.json.
  • Add "default": true for runtime.graphql.enabled in dab.draft.schema.json.

Comment thread schemas/dab.draft.schema.json
@Aniruddh25 Aniruddh25 enabled auto-merge (squash) April 24, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Review In Progress

Development

Successfully merging this pull request may close these issues.

Group 4: Missing/Invalid Default Value [Bug]: Invalid default runtime.graphql.enabled [Bug]: Invalid default runtime.rest.enabled

4 participants