feat: structured observability via two-layer interceptor system#74

Merged

xuxife merged 30 commits into

mainfrom

structured-event-sink

May 7, 2026

Commits on May 6, 2026

docs: add step interceptor design spec

Xingfei Xu
and
claude
committed
docs: revise interceptor design spec based on review

Xingfei Xu
and
claude
committed
docs: remove Start from AttemptInfo

Xingfei Xu
and
claude
committed
docs: add step interceptor implementation plan

Xingfei Xu
and
claude
committed
feat: add interceptor public types and EventType constants
Xingfei Xu
committed
feat: add NewStepEventSink and NewAttemptEventSink
Xingfei Xu
committed
feat: introduce stepExecution, add StepInterceptors/AttemptInterceptors to Workflow

Xingfei Xu
and
claude
committed
feat: SubWorkflow implements InterceptorReceiver for interceptor propagation
Xingfei Xu
committed
test: verify Retrying event attempt numbers are correctly sequenced

Xingfei Xu
and
claude
committed
test: add no-interceptor regression test and final race check
Xingfei Xu
committed
fix: make EventType a distinct named type, use prefixed terminal constants
Xingfei Xu
committed
fix: PrependInterceptors once per step, not per attempt; add regression test

Xingfei Xu
and
claude
committed
chore: fill and archive openspec change structured-event-sink

Xingfei Xu
and
claude
committed
fix: address Codex review issues in interceptor implementation

Xingfei Xu
and
claude
committed
chore: resolve merge conflict with main (StepResult.FinishedAt + unlease order)

Xingfei Xu
and
claude
committed
refactor: move Retrying event ownership from StepInterceptor to AttemptInterceptor

Xingfei Xu
and
claude
committed
refactor: remove redundant private statusFromError, use public StatusFromError

Xingfei Xu
and
claude
committed
refactor: add Event prefix to all EventType constants for consistency

Xingfei Xu
and
claude
committed
refactor: remove Retrying event and retryNotifier side-channel

Xingfei Xu
and
claude
committed
refactor: remove EventSink/WorkflowEvent; replace event.go with interceptor.go

Xingfei Xu
and
claude
committed
simplify interceptor API: remove StepInfo/AttemptInfo wrappers

Xingfei Xu
and
claude
committed
move PrependInterceptors to Workflow + add IsolateInterceptors opt-out

Xingfei Xu
and
claude
committed
add openspec/specs/step-interceptor reflecting current API

Xingfei Xu
and
claude
committed

Commits on May 7, 2026

fix: PrependInterceptors must not accumulate across Do() runs

Xingfei Xu
and
claude
committed
evaluate Condition inline in tick(), remove scheduled sentinel

Xingfei Xu
and
claude
committed
address Copilot review: panic protection, lifecycle, doc accuracy

Xingfei Xu
and
claude
committed
remove PR-introduced superpowers docs and archived OpenSpec changes

Xingfei Xu
and
claude
committed
clarify per-iteration locals in interceptor chain builders + UT guards

Xingfei Xu
and
claude
committed
restore #73 archived change accidentally deleted

Xingfei Xu
and
claude
committed
move comment
Xingfei Xu
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: structured observability via two-layer interceptor system#74

feat: structured observability via two-layer interceptor system#74
xuxife merged 30 commits into
mainfrom
structured-event-sink

Commits on May 6, 2026

docs: add step interceptor design spec

docs: revise interceptor design spec based on review

docs: remove Start from AttemptInfo

docs: add step interceptor implementation plan

feat: add interceptor public types and EventType constants

feat: add NewStepEventSink and NewAttemptEventSink

feat: introduce stepExecution, add StepInterceptors/AttemptInterceptors to Workflow

feat: SubWorkflow implements InterceptorReceiver for interceptor propagation

test: verify Retrying event attempt numbers are correctly sequenced

test: add no-interceptor regression test and final race check

fix: make EventType a distinct named type, use prefixed terminal constants

fix: PrependInterceptors once per step, not per attempt; add regression test

chore: fill and archive openspec change structured-event-sink

fix: address Codex review issues in interceptor implementation

chore: resolve merge conflict with main (StepResult.FinishedAt + unlease order)

refactor: move Retrying event ownership from StepInterceptor to AttemptInterceptor

refactor: remove redundant private statusFromError, use public StatusFromError

refactor: add Event prefix to all EventType constants for consistency

refactor: remove Retrying event and retryNotifier side-channel

refactor: remove EventSink/WorkflowEvent; replace event.go with interceptor.go

simplify interceptor API: remove StepInfo/AttemptInfo wrappers

move PrependInterceptors to Workflow + add IsolateInterceptors opt-out

add openspec/specs/step-interceptor reflecting current API

Commits on May 7, 2026

fix: PrependInterceptors must not accumulate across Do() runs

evaluate Condition inline in tick(), remove scheduled sentinel

address Copilot review: panic protection, lifecycle, doc accuracy

remove PR-introduced superpowers docs and archived OpenSpec changes

clarify per-iteration locals in interceptor chain builders + UT guards

restore #73 archived change accidentally deleted

move comment