Skip to content

Add support for new Additive Capabilities#32

Merged
matthchr merged 1 commit intoAzure:mainfrom
matthchr:matthchr/fix-parsing
Apr 1, 2026
Merged

Add support for new Additive Capabilities#32
matthchr merged 1 commit intoAzure:mainfrom
matthchr:matthchr/fix-parsing

Conversation

@matthchr
Copy link
Copy Markdown
Member

@matthchr matthchr commented Apr 1, 2026

  • Regenerate testdata
  • Add tests
  • Fix bug in testdata generation tool that caused v2 and v1 to be different. Moved both to scan all regions (not every VM size is available in eastus, better to scan everything it gives a more robust test)

@matthchr matthchr force-pushed the matthchr/fix-parsing branch from e9cb487 to f47f78c Compare April 1, 2026 20:36
* Regenerate testdata
* Add tests
* Fix bug in testdata generation tool that caused v2 and v1 to be
  different. Moved both to scan all regions (not every VM size is
  available in eastus, better to scan everything it gives a more robust
  test)
@matthchr matthchr force-pushed the matthchr/fix-parsing branch from f47f78c to c50cd13 Compare April 1, 2026 20:38
Copy link
Copy Markdown
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis
Copy link
Copy Markdown
Member

do we still want to incorporate #25 to make the format compatible w/ compute.SKU, or should I close that PR?

@matthchr matthchr changed the title Add support for new Addititive Capacity Add support for new Additive Capabilities Apr 1, 2026
@matthchr
Copy link
Copy Markdown
Member Author

matthchr commented Apr 1, 2026

do we still want to incorporate #25 to make the format compatible w/ compute.SKU, or should I close that PR?

I don't have the full context on the need/goal there -- maybe a question for @tallaxes

@matthchr matthchr merged commit 314acc0 into Azure:main Apr 1, 2026
2 checks passed
@matthchr matthchr deleted the matthchr/fix-parsing branch April 1, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants