Skip to content

Allow manual cancellation to be propagated#1113

Closed
wolfgang-desalvador wants to merge 2 commits intomainfrom
wdesalvador/review-cancellation-condition
Closed

Allow manual cancellation to be propagated#1113
wolfgang-desalvador wants to merge 2 commits intomainfrom
wdesalvador/review-cancellation-condition

Conversation

@wolfgang-desalvador
Copy link
Copy Markdown
Collaborator

This pull request updates the jobs/competitive-test.yml pipeline configuration to improve job cancellation handling and refine job execution conditions. The main changes are the addition of a configurable cancellation timeout and an updated job condition to prevent execution if the job is already canceled.

Pipeline configuration improvements:

  • Added a new parameter cancellation_timeout_in_minutes with a default value of 5 minutes, allowing customization of the cancellation timeout for the job.
  • Set the cancelTimeoutInMinutes property in the job definition to use the new parameter, enabling the cancellation timeout feature.

Job execution logic:

  • Updated the job condition to include not(canceled()), ensuring the job does not run if it has already been canceled.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the jobs/competitive-test.yml Azure Pipelines job configuration to better handle manual cancellations by making cancellation timeout configurable and preventing job execution when the run is already canceled.

Changes:

  • Added a cancellation_timeout_in_minutes parameter (default: 5) and wired it to cancelTimeoutInMinutes.
  • Updated the job condition to include not(canceled()) in addition to the existing manual/scheduled gating logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants