Allow manual cancellation to be propagated#1113
Closed
wolfgang-desalvador wants to merge 2 commits intomainfrom
Closed
Allow manual cancellation to be propagated#1113wolfgang-desalvador wants to merge 2 commits intomainfrom
wolfgang-desalvador wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the jobs/competitive-test.yml Azure Pipelines job configuration to better handle manual cancellations by making cancellation timeout configurable and preventing job execution when the run is already canceled.
Changes:
- Added a
cancellation_timeout_in_minutesparameter (default: 5) and wired it tocancelTimeoutInMinutes. - Updated the job
conditionto includenot(canceled())in addition to the existing manual/scheduled gating logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
jobs/competitive-test.ymlpipeline configuration to improve job cancellation handling and refine job execution conditions. The main changes are the addition of a configurable cancellation timeout and an updated job condition to prevent execution if the job is already canceled.Pipeline configuration improvements:
cancellation_timeout_in_minuteswith a default value of 5 minutes, allowing customization of the cancellation timeout for the job.cancelTimeoutInMinutesproperty in the job definition to use the new parameter, enabling the cancellation timeout feature.Job execution logic:
conditionto includenot(canceled()), ensuring the job does not run if it has already been canceled.