Refactor RMS DQN pipeline with modular Double DQN implementation#1
Refactor RMS DQN pipeline with modular Double DQN implementation#1BEZOUI wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| priority = int( | ||
| np.clip( | ||
| self.random_state.choice( | ||
| [1, 2, 3, 4, 5], | ||
| p=[ | ||
| 1 - config.high_priority_share - config.rush_job_share, | ||
| 0.25, | ||
| 0.22, | ||
| config.high_priority_share, | ||
| config.rush_job_share, |
There was a problem hiding this comment.
Normalise priority sampling probabilities
In _generate_synthetic_scenarios the probability vector passed to self.random_state.choice is p=[1 - config.high_priority_share - config.rush_job_share, 0.25, 0.22, config.high_priority_share, config.rush_job_share]. Because the first term already accounts for the high and rush shares, adding the fixed 0.25 and 0.22 causes the probabilities to always sum to 1.47. numpy.random.Generator.choice will raise ValueError: probabilities do not sum to 1 as soon as synthetic data generation runs, so prepare_data_bundle() and the entire training pipeline fail before starting. The distribution should be normalised so the probabilities sum to 1.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_690b300653088324910698997e76e9e2