fix download mirrors#6
Draft
mtran-code wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow/scripts/download_resource.pyhelper that downloads or copies resources atomically, rejects HTML verification/error pages, and validates gzip/zip content where expected.Root cause
The DepMap portal download endpoints can return an HTML verification page with HTTP 200. Rules using raw
curl -Lcould either fail later withgunzip: unknown compression formator silently save HTML into raw data outputs.Validation
uvx ruff format workflow/scripts/download_resource.pyuv run python -m py_compile workflow/scripts/download_resource.pyhttps://data.broadinstitute.org/ccle/...mirror URLs withcurl -fsSI; all returned reachable non-HTML responses.Cell_lines_annotations_20181226.txtthrough the helper.gencode.v19.genes.v7_model.patched_contigs.gtf.gzthrough the helper.uvx --python 3.11 --from snakemake==7.32.4 --with pulp==2.7.0 snakemake --dryrun --cores 1uvx --python 3.11 --from snakemake==7.32.4 --with pulp==2.7.0 snakemake --cores 1 -F metadata/Cell_lines_annotations_20181226.txt rawdata/epigenetics/methylation/enhancer_cpg_clusters.tsvgit diff --checkNotes
The remaining DepMap portal URLs are current/public-release files without confirmed static mirrors in this pass:
OmicsSomaticMutations.csv,OmicsCNGeneWGS.csv,OmicsCNSegmentsWGS.csv, andCCLE_miRNA_MIMAT.csv. These now fail with an explicit validation error if the portal returns a verification page.