This repository was archived by the owner on Oct 31, 2024. It is now read-only.
Open
Conversation
Contributor
brinxmat
commented
Jan 19, 2023
brinxmat
commented
- Forces construction of identifiable organizations (ones with URIs)
- Removes underspecified organizations
ketilaa
reviewed
Jan 20, 2023
Contributor
ketilaa
left a comment
ketilaa
left a comment
There was a problem hiding this comment.
What code is it the Brage import uses to add affiliations for contributors? Or do we just let them provide faulty data and fixes it on the way to the database?
| @@ -0,0 +1,29 @@ | |||
| package no.unit.nva; | |||
Contributor
There was a problem hiding this comment.
How will returning null behave when we are parsing a list of Organizations?
ketilaa
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.