Skip to content

hotfix/test-coverage-xmas-ed#620

Draft
StigNorland wants to merge 9 commits into
mainfrom
hotfix/test-coverage-xmas-ed
Draft

hotfix/test-coverage-xmas-ed#620
StigNorland wants to merge 9 commits into
mainfrom
hotfix/test-coverage-xmas-ed

Conversation

@StigNorland

Copy link
Copy Markdown
Contributor

No description provided.

@StigNorland StigNorland self-assigned this Dec 16, 2024
@github-actions

github-actions Bot commented Dec 16, 2024

Copy link
Copy Markdown

Test Results

 34 files  +1   34 suites  +1   50s ⏱️ -2s
911 tests +2  908 ✅ +2  3 💤 ±0  0 ❌ ±0 
944 runs  +2  941 ✅ +2  3 💤 ±0  0 ❌ ±0 

Results for commit 4e5f35c. ± Comparison against base commit 695ef66.

This pull request removes 71 and adds 73 tests. Note that renamed tests count towards both.
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=CwjtAkcPuhyiKZ1d7k, documentIdentifier=null], resource={"RK60Hrr34o5jN":{"Bu7fjN9VKUU2KdMfnJ":"quGzQkmuIDy5LyE","eDFnl9RUIQshW4me":"S62ezmFtwXtgYQBpG","4yxUW0zv05bQ":"a855QnXJvgqtMC","bzQubBYy0Nl":"JzRmlEkVQ7K64NUMt","BJ7HAvX4A3":"h9EyCOUalaS9czE"},"VQpe4LgGwpLpU":{"oNyTIm4IzMf8":"eWEpBOckabZlIXsxPJl","0iArymPLPdtUMcdZb":"UeemWkXsO9u9","odiBIewVJrir4":"rYWGGsOBK2Rz96","cQh4BTaPrgh9hLR":"kgUuoBgp8Y2xgGYrYI","KzDP75F13HFBp1i24":"tEExr9yQxD"…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=0193c183ffaa-0636428a-4d24-45d9-981f-2d23ba5120c8], resource={"H0SCaOhJSKxVTO39":{"DiTMReNSWiOPp":"FiyCaeJcAhq5y","Rzi0vOwxoIkpnYzF":"lrgwolnG89m6tMjXJCf","9TxVu45mhEhww07X6v":"cHikovpcdJkTU3i","Zw9NQhJebQ":"mBUbKcHHKFQ6iuHLJGQ","v8PYgf8a6n7":"MY9BQnzabPBNXEU"},"LAywGnBCpifWCdFRcfj":{"qb6p6I8xca64LEh":"WATOcq0lomoSSqjTXPD","lPrfVG8f6Aa6RhI3V9":"6Y4u1LcqERNe0u3","RYrGjRiA4sRnhdeFIWJ":"hQRftxRvoN0QSp6","7G67iPFtEFF6…
no.unit.nva.search.ticket.TicketClientTest ‑ [10] https://x.org/?size=22&aggregation=all&CREATED_DATE=,2023-06, 5
no.unit.nva.search.ticket.TicketClientTest ‑ [11] https://x.org/?size=22&aggregation=all&CUSTOMER_ID=https://api.dev.nva.aws.unit.no/customer/bb3d0c0c-5065-4623-9b98-5810983c2478, 20
no.unit.nva.search.ticket.TicketClientTest ‑ [12] https://x.org/?size=22&aggregation=all&CUSTOMER_ID_NOT=bb3d0c0c-5065-4623-9b98-5810983c2478, 0
no.unit.nva.search.ticket.TicketClientTest ‑ [13] https://x.org/?size=22&aggregation=all&ID=https://api.dev.nva.aws.unit.no/publication/018de5050448-3f5ead68-8a74-4c24-826d-fe871277c0d1/ticket/018de5060dd0-3e2570f5-3d56-4479-b79e-4410b81626c7, 1
no.unit.nva.search.ticket.TicketClientTest ‑ [14] https://x.org/?size=22&aggregation=all&ID=018de5060dd0-3e2570f5-3d56-4479-b79e-4410b81626c7, 1
no.unit.nva.search.ticket.TicketClientTest ‑ [15] https://x.org/?size=22&aggregation=all&ID_NOT=018de5060dd0-3e2570f5-3d56-4479-b79e-4410b81626c7, 19
no.unit.nva.search.ticket.TicketClientTest ‑ [16] https://x.org/?size=22&aggregation=all&ID_NOT=018de5060dd0-3e2570f5-3d56-4479-b79e-4410b81626c7,018de5044416-7a3b7a74-978f-45fb-a743-c9c0b0d39e65, 18
no.unit.nva.search.ticket.TicketClientTest ‑ [17] https://x.org/?size=22&aggregation=all&MESSAGES=en+DOI, 1
…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=IKrh3A4DHTjS, documentIdentifier=null], resource={"FJxsd8Mwhy4":{"qB7x3Qwezkiec4ikUu":"ruDAly5OmkH","bleDSVakjfgj37kfi":"f6Pb6Gcs5SBm9hbl","S7SxAkRMylcIGF":"har3uJQtkDLdA","r4xIiidfLow11eaq61M":"ETBjxiq7o97ILKPz6","pmvjQnLRwBSj5tc":"PWh8Hnj4aWm"},"2hm9sw3Q1Armgk":{"v0tuuJrLyN4ZJO7z":"3t5gWcLMxuWk","3ImC5RtyZF":"zTaiI9ciN4Sp","q3wBNraOw1rVk1sZiW":"w4j71kt6HNjmO2FQuv","FS2YQQd1OIhtWYFx":"DhNXR9dxxl","JIMvBG5U6ie7JS":"qVB2edQQfZHxtp"},"hbDHj…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=0193d5186538-5ff664f1-a448-403b-9c34-3b03816b8aae], resource={"ZkQQIQZTcSBt5JQpKC5":{"aNnnrw4npMMj2cRY":"cTYNF72ahlQZpV","B3EfzPfu7HijM":"43sMq9kgvOna56HdP8","UYGy5Yebmm":"UiCW9zwT2uTBDJ7Dsw","vj5swVXtvU3":"OKwoGOOZRMXICF0Qks","BXEfKSQ7rhq9":"7nEhvtVak0XSnxsFjH"},"C6f5SH2inPBB1":{"DN2PP7jPbbZ2":"wfwdaVB6TlkjiE1w","2nQn6KaUgSNtFQcYh":"cBbvQNxdG7Xqt6JjT2","G8lKpzdodndBw95Mkvs":"fzZiBanG1xqjx7G","QmDT1tU9b5KKb":"GFrC…
no.unit.nva.search.SearchResourceHandlerTest ‑ shouldReturnContentIn20241201Format()
no.unit.nva.search.SearchResourceHandlerTest ‑ shouldReturnContentInLegacyFormat()
no.unit.nva.search.ticket.TicketClientTest ‑ [10] https://x.org/?size=22&aggregation=all&CREATED_DATE=2023,, 17
no.unit.nva.search.ticket.TicketClientTest ‑ [11] https://x.org/?size=22&aggregation=all&CREATED_DATE=2023,2024, 17
no.unit.nva.search.ticket.TicketClientTest ‑ [12] https://x.org/?size=22&aggregation=all&CREATED_DATE=2024, 15
no.unit.nva.search.ticket.TicketClientTest ‑ [13] https://x.org/?size=22&aggregation=all&CUSTOMER_ID=https://api.dev.nva.aws.unit.no/customer/bb3d0c0c-5065-4623-9b98-5810983c2478, 20
no.unit.nva.search.ticket.TicketClientTest ‑ [14] https://x.org/?size=22&aggregation=all&CUSTOMER_ID_NOT=bb3d0c0c-5065-4623-9b98-5810983c2478, 0
no.unit.nva.search.ticket.TicketClientTest ‑ [15] https://x.org/?size=22&aggregation=all&ID=018de5060dd0-3e2570f5-3d56-4479-b79e-4410b81626c7, 1
…

♻️ This comment has been updated with latest results.

@truhacevkir truhacevkir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss description :)
Will it fix facets in the "bell" vs "curator task list"?

Are there any tests that can verify it?

@StigNorland StigNorland marked this pull request as draft December 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants