844 add solar radiation to pluginopenfoam#874
Open
hochbean wants to merge 10 commits intodevelopmentfrom
Open
Conversation
veronikarichter
requested changes
Mar 17, 2026
Member
veronikarichter
left a comment
veronikarichter
left a comment
There was a problem hiding this comment.
Thank you for the great work! Just some minor comments. Please double check the heat flux calculations for the case without solar radiation.
Comment on lines
107
to
+114
| self.power = timestep_df[res_key + ( | ||
| 'Surface Window Net Heat Transfer ' | ||
| 'Rate [W](Hourly)')] | ||
| # remove solar load for realistic window surface bc | ||
| self.power -= timestep_df[res_key + ('Surface Window ' | ||
| 'Transmitted Solar ' | ||
| 'Radiation Rate [W](' | ||
| 'Hourly)')] |
Member
There was a problem hiding this comment.
Could you please add a comment to the code how the "surface window net heat transfer rate" is calculated and how the transmitted solar radiation rate is removed here? Currently, for ALL Windows (regardless of self.add_solar_radiation == True or not), the transmitted solar radiation rate is removed.
Member
There was a problem hiding this comment.
This change may be the reason that the regression tests currently fail even if these tests do not consider add_solar_radiation.
bim2sim/plugins/PluginOpenFOAM/bim2sim_openfoam/openfoam_elements/stlbound.py
Outdated
Show resolved
Hide resolved
bim2sim/plugins/PluginOpenFOAM/bim2sim_openfoam/task/init_openfoam_setup.py
Outdated
Show resolved
Hide resolved
bim2sim/plugins/PluginOpenFOAM/bim2sim_openfoam/task/init_openfoam_setup.py
Show resolved
Hide resolved
bim2sim/plugins/PluginOpenFOAM/bim2sim_openfoam/task/set_boundary_conditions.py
Show resolved
Hide resolved
bim2sim/plugins/PluginOpenFOAM/bim2sim_openfoam/task/set_boundary_conditions.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #844
Adds the option of using solar radiation in OpenFOAM simulations. Extends the documentation of the PluginOpenFOAM by installation instructions for a modified version of OpenFOAM uploaded here: https://github.com/BIM2SIM/OpenFOAM-v2206S