Update 8x8 scint geometry to a working one from a non working#206
Merged
Update 8x8 scint geometry to a working one from a non working#206
Conversation
Kindly provided by Amirreza Hashemi
Member
|
@ggalgoczi do you want to add a test/example using this updated gdml file before we merge? |
Contributor
Author
|
Sure, I will. |
Contributor
Author
|
Added the test but the build fails with Any idea what could cause this @plexoos ? |
Contributor
Author
|
Forgot to add permission to the test, will do with |
Member
|
Should be an easy fix, agree? |
Contributor
Author
Yes, just did it |
…tical test Add the missing 8x8SiPM_crystal.json config file that GPUPhotonSource requires. Replace fixed 5% tolerance with a 3-sigma Poisson statistical test for comparing GPU vs CPU hit counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kindly provided by Amirreza Hashemi.