Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SysRap’s CMake configuration to explicitly declare and propagate a GLM dependency via CMake package discovery and an imported target, aligning the build with SysRap’s existing GLM header usage.
Changes:
- Add
find_package(glm REQUIRED)to SysRap’s CMake configuration. - Link
SysRapagainstglm::glmso downstream targets can inherit GLM include usage through target linkage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| find_package(plog REQUIRED) | ||
| find_package(GLEW REQUIRED) | ||
| find_package(glfw3 REQUIRED) | ||
| find_package(glm REQUIRED) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.