-
Notifications
You must be signed in to change notification settings - Fork 4
docs: rename project to simphony #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -44,46 +44,46 @@ environment, ensure that your system has the following tools installed: | |||||
| ## Build | ||||||
|
|
||||||
| ```shell | ||||||
| git clone https://github.com/BNLNPPS/eic-opticks.git | ||||||
| cmake -S eic-opticks -B build | ||||||
| git clone https://github.com/BNLNPPS/simphony.git | ||||||
| cmake -S simphony -B build | ||||||
| cmake --build build | ||||||
| ``` | ||||||
|
|
||||||
| ## Docker | ||||||
|
|
||||||
| Build latest `eic-opticks` image by hand: | ||||||
| Build latest `simphony` image by hand: | ||||||
|
|
||||||
| ```shell | ||||||
| docker build -t ghcr.io/bnlnpps/eic-opticks:latest https://github.com/BNLNPPS/eic-opticks.git | ||||||
| docker build -t ghcr.io/bnlnpps/simphony:latest https://github.com/BNLNPPS/simphony.git | ||||||
| ``` | ||||||
|
|
||||||
| Build and run for development: | ||||||
|
|
||||||
| ```shell | ||||||
| docker build -t ghcr.io/bnlnpps/eic-opticks:develop --target=develop . | ||||||
| docker build -t ghcr.io/bnlnpps/simphony:develop --target=develop . | ||||||
| ``` | ||||||
|
|
||||||
| Example commands for interactive and non-interactive tests: | ||||||
|
|
||||||
| ```shell | ||||||
| docker run --rm -it -v $HOME/.Xauthority:/root/.Xauthority -e DISPLAY=$DISPLAY --net=host ghcr.io/bnlnpps/eic-opticks:develop | ||||||
| docker run --rm -it -v $HOME/.Xauthority:/root/.Xauthority -e DISPLAY=$DISPLAY --net=host ghcr.io/bnlnpps/simphony:develop | ||||||
|
|
||||||
| docker run --rm -it -v $HOME:/esi -v $HOME/eic-opticks:/workspaces/eic-opticks -e DISPLAY=$DISPLAY -e HOME=/esi --net=host ghcr.io/bnlnpps/eic-opticks:develop | ||||||
| docker run --rm -it -v $HOME:/esi -v $HOME/simphony:/workspaces/simphony -e DISPLAY=$DISPLAY -e HOME=/esi --net=host ghcr.io/bnlnpps/simphony:develop | ||||||
|
|
||||||
| docker run ghcr.io/bnlnpps/eic-opticks bash -c 'simg4ox -g tests/geom/sphere_leak.gdml -m tests/run.mac -c sphere_leak' | ||||||
| docker run ghcr.io/bnlnpps/simphony bash -c 'simg4ox -g tests/geom/sphere_leak.gdml -m tests/run.mac -c sphere_leak' | ||||||
|
||||||
| docker run ghcr.io/bnlnpps/simphony bash -c 'simg4ox -g tests/geom/sphere_leak.gdml -m tests/run.mac -c sphere_leak' | |
| docker run ghcr.io/bnlnpps/simphony:develop bash -c 'simg4ox -g tests/geom/sphere_leak.gdml -m tests/run.mac -c sphere_leak' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep Singularity bind paths aligned with image layout
The Singularity example now binds to /opt/simphony and /workspaces/simphony, but the container is built around /opt/eic-opticks and /workspaces/eic-opticks (OPTICKS_PREFIX/OPTICKS_HOME in Dockerfile). With these new bind points, mounted host artifacts are not placed where the runtime expects them, which breaks the documented development/run workflow.
Useful? React with 👍 / 👎.
Copilot
AI
Apr 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docker build commands are missing the required build context argument (e.g. .). As written, docker build -t ... --target=... will fail; please add the context path (and optionally -f Dockerfile if needed).
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||||||
| Assuming eic-opticks is properly installed on the system, compile and run this | ||||||||||
| Assuming Simphony is properly installed on the system, compile and run this | ||||||||||
| example by simply doing from this directory: | ||||||||||
|
Comment on lines
+1
to
2
|
||||||||||
| Assuming Simphony is properly installed on the system, compile and run this | |
| example by simply doing from this directory: | |
| Assuming the `eic-opticks` CMake package is properly installed on the system, | |
| compile and run this example by simply doing from this directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documented
docker runcommand mounts the host checkout into/workspaces/simphony, but the image is configured to use/workspaces/eic-opticks(OPTICKS_HOMEandWORKDIRinDockerfile). In this setup, users following the README will execute against the baked-in source tree instead of their mounted checkout, so local edits and debugging changes are silently ignored.Useful? React with 👍 / 👎.