[codex] Support PostgreSQL index types in DBML parser#98
Draft
TheTrustedAdvisor wants to merge 1 commit into
Draft
[codex] Support PostgreSQL index types in DBML parser#98TheTrustedAdvisor wants to merge 1 commit into
TheTrustedAdvisor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a compatibility layer for DBML indexes that use PostgreSQL index methods currently rejected by
@dbml/core, such asgist,gin,brin, andspgist.Details
@dbml/corerejects DBML index settings likegeom_lv95 [type: gist]before this package can transform the parsed schema. The parser currently accepts onlybtreeandhash; this behavior is still present in@dbml/core@8.2.5.This change normalizes unsupported PostgreSQL index methods to a parser-supported type only inside
indexes { ... }blocks, parses the schema, then restores the original index methods on the parsed indexes before validation and transformation.Validation
corepack yarn workspace dbml-to-json-table-schema test --runInBandlint-staged, includingtsc-files --noEmit,eslint --fix, andprettier --writeNotes
A true upstream fix would be to extend the
@dbml/coreDBML grammar to accept these PostgreSQL index methods directly. Until then, this keeps the workaround local and narrowly scoped.