Skip to content

auto join 1:1 relations#249

Open
frida-161 wants to merge 10 commits intoBRGM:masterfrom
gbd-consult:feature/248_auto_join
Open

auto join 1:1 relations#249
frida-161 wants to merge 10 commits intoBRGM:masterfrom
gbd-consult:feature/248_auto_join

Conversation

@frida-161
Copy link
Copy Markdown
Contributor

This PR implements the Auto Join of 1:1 relations as described in Issue #248

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 11, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.05%. Comparing base (84de3da) to head (48ed152).
⚠️ Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
...lication_schema_toolbox/core/load_gmlas_in_qgis.py 0.00% 13 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   19.12%   19.05%   -0.08%     
==========================================
  Files          42       42              
  Lines        3708     3727      +19     
  Branches      610      561      -49     
==========================================
+ Hits          709      710       +1     
- Misses       2947     2963      +16     
- Partials       52       54       +2     
Files with missing lines Coverage Δ
...plication_schema_toolbox/gui/import_gmlas_panel.py 0.00% <ø> (ø)
...lication_schema_toolbox/core/load_gmlas_in_qgis.py 75.39% <0.00%> (-6.33%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frida-161
Copy link
Copy Markdown
Contributor Author

@Guts Do you think we could get this feature merged?

@Guts Guts self-assigned this Nov 9, 2022
@kannes
Copy link
Copy Markdown

kannes commented Feb 9, 2023

I'd suggest a tiny change to the option label: "Automatically join 1:1 relation tables" or something similar to make it more clear what this option does. There is enough space.

@frida-161
Copy link
Copy Markdown
Contributor Author

I'd suggest a tiny change to the option label: "Automatically join 1:1 relation tables" or something similar to make it more clear what this option does. There is enough space.

Thanks for the suggestions. Now its much clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants