[rpc] AsyncRPCOperation: std::move instead of assignment#33
Open
ch4ot1c wants to merge 3 commits into
Open
Conversation
ch4ot1c
changed the title
jc23424
reviewed
Jul 15, 2018
Contributor
jc23424
left a comment
jc23424
left a comment
There was a problem hiding this comment.
utACK
Can consider upstreaming to zcash part of this commit
| set_state(OperationStatus::READY); | ||
| } | ||
|
|
||
| AsyncRPCOperation::AsyncRPCOperation(const AsyncRPCOperation& o) : |
Contributor
There was a problem hiding this comment.
should consider getting rid of this copy constructor too for same reason
ch4ot1c
force-pushed
the
improvement/AsyncRPCOperation-assignment
branch
2 times, most recently
from
cba6ca1 to
0a6f2f1
Compare
ch4ot1c
force-pushed
the
improvement/AsyncRPCOperation-assignment
branch
from
0a6f2f1 to
d1a02b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.