Validation of conflicting measurment lists#55
Merged
sreekanthkura7 merged 3 commits intoBUNPC:mainfrom Aug 7, 2025
Merged
Conversation
Contributor
|
@HanBnrd, There were a few issues with the code we wrote earlier, which I’ve now fixed. I created three SNIRF files—one with just measurementList, one with just measurementLists, and one with both—to test the updated code. We can go through the changes and approve the PR in tomorrow’s meeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REQUIRED_DATASET_MISSINGvalidation issuesTODOs:
measurementListandmeasurementListsCONFLICTING_FIELDS_PRESENTerrorPing @sreekanthkura7
@sstucker, we were wondering if introducing a new error code (after the
OKcode) will be okay with the rest of the validation?