[compat-sync] Back light.setEnabled + engine Version; sync to BJS 958a8db#401
Merged
Merged
Conversation
babylon-compat-sync
Bot
added
automation
compat
📋 parity — Test ReportBuild 20260710.4 · merge @ f91d4c7 |
ryantrem
marked this pull request as ready for review
July 16, 2026 23:55
ryantrem
enabled auto-merge (squash)
July 16, 2026 23:55
ryantrem
approved these changes
Jul 16, 2026
Lite Playground - Static SiteBuild 20260716.13 - merge @ be9f4f0 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @babylonjs/lite-compat compatibility layer to match Babylon.js commit 958a8db, restoring Light.setEnabled(...) behavior and adding Babylon.js-style AbstractEngine.Version / AbstractEngine.NpmPackage statics.
Changes:
- Add
AbstractEngine.Version/AbstractEngine.NpmPackagestatics and corresponding unit coverage. - Implement
Light.intensityproxying +Light.setEnabled(...)by parking logical intensity and zeroing Lite intensity while disabled. - Update compat status documentation and add dedicated light toggle tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/babylon-lite-compat/COMPAT-STATUS.md | Updates sync SHA/date and marks light.setEnabled(false) + engine version statics as supported. |
| packages/babylon-lite-compat/src/engine/engine.ts | Adds AbstractEngine.Version / NpmPackage statics backed by Lite VERSION. |
| packages/babylon-lite-compat/src/lights/lights.ts | Implements setEnabled by manipulating Lite intensity while preserving caller-visible intensity. |
| packages/babylon-lite-compat/tests/engine-scene-api.test.ts | Adds assertions for engine version statics on base + subclasses. |
| packages/babylon-lite-compat/tests/lights.test.ts | Adds unit tests validating setEnabled intensity parking/restore behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lab - Static SiteBuild 20260716.13 - merge @ be9f4f0 |
… in NpmPackage Addresses PR review feedback: - NpmPackage now uses this.Version so subclasses overriding Version are respected. - Light intensity/setEnabled writes bump the underlying Lite _lightVersion so changes reach the shared lights UBO. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Lite Playground - Static SiteBuild 20260717.5 - merge @ 2c9c569 |
Lab - Static SiteBuild 20260717.5 - merge @ 2c9c569 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of
@babylonjs/lite-compatagainst the latest Babylon.js and Babylon Lite changes,produced by the
update-compat-layerskill.Synced against BJS commit:
958a8dbed4e263d412ee9255ae747299043de19fValidation (run independently by the pipeline)
Changed files
ackages/babylon-lite-compat/COMPAT-STATUS.mdpackages/babylon-lite-compat/src/engine/engine.tspackages/babylon-lite-compat/src/lights/lights.tspackages/babylon-lite-compat/tests/engine-scene-api.test.tspackages/babylon-lite-compat/tests/lights.test.ts