OpenPBR: Ensures relative IOR goes to one as the specular_weight goes to zero - #18739
Open
MiiBond wants to merge 1 commit into
Open
OpenPBR: Ensures relative IOR goes to one as the specular_weight goes to zero#18739MiiBond wants to merge 1 commit into
MiiBond wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative IOR of base layer should move to match outer layer as weight goes to zero. This fixes the same problem found recently in the Adobe open source OpenPBR BSDF:
adobe/openpbr-bsdf#29
I also added a visual test for base specular with coat. The base specular (roughness 0.5) shouldn't be visible when
specular_weightgoes to 0.0 with a coat.