Re-enable blur-cube-with-the-effect-renderer validation test#1763
Merged
bkaradzic-microsoft merged 2 commits intoJul 7, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables the blur-cube-with-the-effect-renderer Playground validation test by removing its excludeFromAutomaticTesting entry, allowing it to run in the automated native validation suite.
Changes:
- Removed
excludeFromAutomaticTestingand associatedreasonforblur-cube-with-the-effect-rendererin the Playground validation catalog.
bkaradzic-microsoft
force-pushed
the
fix/reenable-blur-cube-effect-renderer
branch
from
June 18, 2026 15:22
1da8f15 to
067e50b
Compare
This EffectRenderer fullscreen-pass test rendered all-black on Native because the native engine did not honor depth-test toggles made through engine.depthCullingState.depthTest (used by EffectRenderer). Fixed upstream in the native engine (BabylonJS/Babylon.js#18558); re-enable the test here. Depends on a babylonjs dependency bump that includes the fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The re-enabled validation tests depend on native-engine fixes that landed in babylonjs 9.14.0+ (depthCullingState.depthTest, cube render targets, updateTextureData / engine.name). The Apps lockfile was pinned to 9.9.1, so 'npm ci' installed an engine without those fixes and the tests crashed on the old WebGL-only paths. Bump to 9.15.0 (protocol-compatible: PROTOCOL_VERSION 9). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
force-pushed
the
fix/reenable-blur-cube-effect-renderer
branch
from
July 6, 2026 15:14
067e50b to
2cfc3cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-enables the
blur-cube-with-the-effect-rendererPlayground validation test (#4C900K#2) bydropping its
excludeFromAutomaticTestingentry inconfig.json, and bumps the bundledbabylonjsto 9.15.0 (which contains the paired engine fix) so the test actually passes in CI.
Two commits:
blur-cube-with-the-effect-rendererinApps/Playground/Scripts/config.json.babylonjsto 9.15.0 inApps/package.json+Apps/package-lock.json.Broken out of #1748 so it can merge independently:
#1748 re-enables this same test alongside six single-file-
.ddscube tests, but those six are stillgated on an unmerged cube-loading TS change (BabylonJS/Babylon.js#18567), whereas this test only
needs the already-merged depth-test fix. (#1748 currently still carries a duplicate
blur-cubere-enable; that entry should be dropped there once this lands.)
Why it passes now
The test previously failed pixel comparison because the native engine ignored
depthCullingState.depthTest, so anEffectRendererfullscreen pass produced an all-black frame.That is fixed by BabylonJS/Babylon.js#18558 ("[Native] Honor
depthCullingState.depthTest on the native engine"), merged 2026-06-16 and shipped in
babylonjs9.15.0 — the version this PR now pins. With that fix present in the bundled engine the pass renders
correctly and the test matches its reference image.
Status
part of this PR, so the re-enable no longer depends on a separate future
babylonjsbump.suite —
blur-cube-with-the-effect-renderervalidates. Ready to merge (pending review).