Hotfix/master support to inject product mapper and valid thru conversion #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat: Inject `ProductMapper` in `ProductIngestionSaga` and `BatchProductIngestionSaga`. - feat: Add custom mapper for `validThru` in `ProductMapper`. - test: Update tests to support `ProductMapper` injection.
…rsion** - feat: Add `mapValidThru` method for `validThru` field conversion in `ProductMapper`. - feat: Include `validThru` field mapping in `toPresentation`, `toArrangementItem`, and `toArrangementItemPut` methods. - test: Update test cases to include `validThru` field handling.
… enhance ValidThru mappings and add ProductMapper mocks - Simplify `mapValidThru` logic in `ProductMapper` - Add `ProductMapper` mocks in `BatchProductIngestionSagaTest` and `ProductIngestionSagaTest` - Add test for `validThru` null case in `ProductMapperTest`
jjjasper
requested changes
Jan 19, 2026
Contributor
jjjasper
left a comment
jjjasper
left a comment
There was a problem hiding this comment.
Incomplete tests and possible NPE?
...-ingestion-saga/src/test/java/com/backbase/stream/product/BatchProductIngestionSagaTest.java
Outdated
Show resolved
Hide resolved
...roduct/product-core/src/test/java/com/backbase/stream/product/mapping/ProductMapperTest.java
Outdated
Show resolved
Hide resolved
...roduct/product-core/src/test/java/com/backbase/stream/product/mapping/ProductMapperTest.java
Show resolved
Hide resolved
...am-product/product-core/src/main/java/com/backbase/stream/product/mapping/ProductMapper.java
Show resolved
Hide resolved
…version): remove unused ProductMapper mocks and add ValidThru mapping test - Remove `ProductMapper` mocks from `BatchProductIngestionSagaTest` and `ProductIngestionSagaTest`. - Add new test case for `validThru` non-null mapping in `ProductMapperTest`.
jjjasper
approved these changes
Jan 20, 2026
…pper-and-valid-thru-conversion
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hotfix/master-support-to-inject-product-mapper-and-valid-thru-conversion
mapValidThrumethod forvalidThrufield conversion inProductMapper.validThrufield mapping intoPresentation,toArrangementItem, andtoArrangementItemPutmethods.validThrufield handling.Checklist