fix: close H8 batch-approval classifyToolCall gaps and Telegram class-trust guard (M-1)#55
Merged
Merged
Conversation
…-trust guard (M-1) - classifyToolCall now handles parallel_shell commands, batch_patch paths, and the modern browser tool. - Batch approval card lists every classified command/path and shows full text instead of truncating. - Iterations containing unclassifiable tools no longer receive blanket SetTrustAll. - Telegram approver hides Trust Session for destructive/blocked/unknown/tool_batch and denies trust callbacks for those classes. - Update AGENTS.md and docs/SECURITY.md; add regression tests.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | 81565ab | Commit Preview URL Branch Preview URL |
Jul 18 2026, 11:58 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes H8 and the Telegram half of M-1 from the security roadmap.
H8 — Batch approval card hides
parallel_shell/batch_patch/browserpayloadsinternal/loop/loop.go::classifyToolCallnow understands:parallel_shell— walks thecommandsarray, classifies every command, and surfaces all commands in the batch card.batch_patch— walks thepatchesarray, classifies every path, and surfaces all paths.browser— recognises the modern single-tool schema (action+url) instead of the deadbrowser_navigate/browser_clickcases.classifyToolCall, the loop no longer callsSetTrustAll(true)after the batch approval. Those tools must be approved individually by their own internal gates instead of getting a free pass.M-1 — Telegram class-trust guard
internal/telegram/approver.gonow hides the "Trust Session" button fordestructive,blocked,unknown, and the synthetictool_batchclass.Tests & docs
classifyToolCallcases and the Telegram trust guard.AGENTS.mdanddocs/SECURITY.mdto document the new behavior.