fix: reuse one TTYApprover per process in CLI mode (M-13)#70
Merged
Conversation
shell and parallel_shell created a fresh TTYApprover for every prompt, so the friction counter and trust cache were reset each time and the post-3-approvals friction mode never engaged. Changes: - cmd/odek/shell.go: promptUser now stores the created TTYApprover in t.approver and reuses it on subsequent prompts. - cmd/odek/perf_tools.go: same for parallelShellTool.promptCommand. - Added TestShellTool_PromptUser_ReusesTTYApprover. - Updated docs/SECURITY.md and AGENTS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes CLI and reuse a single TTYApprover instance per process so the friction counter and trust cache persist across prompts (M-13).\n\nChanges:\n- cmd/odek/shell.go and cmd/odek/perf_tools.go store and reuse the TTYApprover.\n- Added TestShellTool_PromptUser_ReusesTTYApprover.\n- Updated docs/SECURITY.md and AGENTS.md.