Update precommit hooks and github action with 10 days cooldown and pin to sha1 commit#2377
Update precommit hooks and github action with 10 days cooldown and pin to sha1 commit#2377seefood merged 5 commits intoBash-it:masterfrom
Conversation
|
#2378 should be merged before for the CI to pass. |
|
see #2379, I think it covers this. not sure I want to lock odwn to specific sha versions, major version should be good enough, no? |
|
note that this PR is still a draft, as I didn't finish the tests.
Nope, tag or releases are not immutable. see for recent exemples: |
|
I thought we could at least trust github's actions/ collection... |
|
Yes, with build attestation, but I don't think it's possible yet with github action to validate it: |
|
The current good practice for action / dependencies should be:
|
|
I should also document how to update with sha pinning and a cooldown of 10 days:
pinact run --update --min-age 10
prek autoupdate --freeze --cooldown-days 10 |
…te-actions * 'master' of github.com:Bash-it/bash-it: Update precommit hooks and github action with 10 days cooldown and pin to sha1 commit (Bash-it#2377)
|
so for completeness: thanks! I'm smarter today :) |
Exactly. I will make another PR to add this information in the readme or in https://github.com/Bash-it/bash-it/blob/master/docs/development.rst |
Description
Update pre-commit hooks and github action with a 10 days cooldown period and pin to sha1 release instead of using tag.
Motivation and Context
Following the multiple supply chain security issue in the node / python ecosystem, pinning to sha seems a good idea.
How Has This Been Tested?
Updates the hooks, and ran the hooks with
prek run -aorpre-commit run -a:Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.